Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing rules fix filter #28027

Merged
merged 9 commits into from Jul 10, 2023
Merged

Parsing rules fix filter #28027

merged 9 commits into from Jul 10, 2023

Conversation

yasta5
Copy link
Contributor

@yasta5 yasta5 commented Jul 10, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-26041

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@yasta5 yasta5 requested a review from evisochek July 10, 2023 09:51
@anara123
Copy link
Contributor

I am going to ForceMerge since the PR fails on unrelated unit tests.

=========================== short test summary info ============================
FAILED Utils/github_workflow_scripts/github_workflow_scripts_tests/link_pr_to_jira_issue_test.py::test_trigger_generic_webhook[True-expected0] - requests_mock.exceptions.NoMockAddress: No mock address: POST http://test.com/instance/execute/GenericWebhook_link_pr_to_jira
FAILED Utils/github_workflow_scripts/github_workflow_scripts_tests/link_pr_to_jira_issue_test.py::test_trigger_generic_webhook[False-expected1] - requests_mock.exceptions.NoMockAddress: No mock address: POST http://test.com/instance/execute/GenericWebhook_link_pr_to_jira
================== 2 failed, 90 passed, 222 warnings in 4.20s ==================

Both of these unit tests are handled in different issue

@evisochek
Copy link
Contributor

I am going to ForceMerge since the PR fails on unrelated unit tests.

=========================== short test summary info ============================
FAILED Utils/github_workflow_scripts/github_workflow_scripts_tests/link_pr_to_jira_issue_test.py::test_trigger_generic_webhook[True-expected0] - requests_mock.exceptions.NoMockAddress: No mock address: POST http://test.com/instance/execute/GenericWebhook_link_pr_to_jira
FAILED Utils/github_workflow_scripts/github_workflow_scripts_tests/link_pr_to_jira_issue_test.py::test_trigger_generic_webhook[False-expected1] - requests_mock.exceptions.NoMockAddress: No mock address: POST http://test.com/instance/execute/GenericWebhook_link_pr_to_jira
================== 2 failed, 90 passed, 222 warnings in 4.20s ==================

Both of these unit tests are handled in different issue

The issue was fixed here:
#28033
no need to force merge

@yasta5 yasta5 merged commit 9725cb2 into master Jul 10, 2023
15 checks passed
@yasta5 yasta5 deleted the Parsing_rules_fix_filter branch July 10, 2023 15:31
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Added filter to parsing rules.

* Added release notes.

* Added release notes.

* Added release notes.

* revert fireeye hx

* revert fireeye hx

* Improved the release notes.
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Added filter to parsing rules.

* Added release notes.

* Added release notes.

* Added release notes.

* revert fireeye hx

* revert fireeye hx

* Improved the release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants