[DBotAverageScore] Migrate to Python, and fix '0' average causing a null value #28030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelYochpaz
changed the title
MichaelYochpaz
force-pushed
the
xsup-26026-fix-dbotaveragescore
branch
2 times, most recently
from
fe33b12
to
83fab98
Compare
|
@DeanArbel adding you since we'll need a force-merge, as a validation fails for removing the previous JS file. |
MichaelYochpaz
force-pushed
the
xsup-26026-fix-dbotaveragescore
branch
from
83fab98
to
322585b
Compare
MichaelYochpaz
changed the title
bziser
reviewed
Jul 10, 2023
Packs/CommonScripts/Scripts/DBotAverageScore/DBotAverageScore.py
Outdated
Show resolved
Hide resolved
Packs/CommonScripts/Scripts/DBotAverageScore/DBotAverageScore.py
Outdated
Show resolved
Hide resolved
Packs/CommonScripts/Scripts/DBotAverageScore/DBotAverageScore.py
Outdated
Show resolved
Hide resolved
Packs/CommonScripts/Scripts/DBotAverageScore/DBotAverageScore.py
Outdated
Show resolved
Hide resolved
Packs/CommonScripts/Scripts/DBotAverageScore/DBotAverageScore.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
MichaelYochpaz
force-pushed
the
xsup-26026-fix-dbotaveragescore
branch
from
501c7b7
to
1c10e21
Compare
# Conflicts: # Packs/CommonScripts/ReleaseNotes/1_11_96.md
Ni-Knight
approved these changes
Jul 10, 2023
bziser
approved these changes
Jul 11, 2023
Packs/CommonScripts/Scripts/DBotAverageScore/DBotAverageScore.yml
Outdated
Show resolved
Hide resolved
Packs/CommonScripts/Scripts/DBotAverageScore/DBotAverageScore.yml
Outdated
Show resolved
Hide resolved
|
@Ni-Knight @bziser @DeanArbel Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
…ull value (demisto#28030) * Rewrite & replace JS script with Python * Update code structure for better unit-tests * Add unit-tests * Ruff auto-fixes * Add release-notes, bump version * Update README.md * Add JavaScript to known words * Minor changes * Apply suggestions from code review Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> * Fix issue where script fails if there is only a single entry * Bump version to resolve conflict * Add release-notes note * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Add types to outputs --------- Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
…ull value (demisto#28030) * Rewrite & replace JS script with Python * Update code structure for better unit-tests * Add unit-tests * Ruff auto-fixes * Add release-notes, bump version * Update README.md * Add JavaScript to known words * Minor changes * Apply suggestions from code review Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> * Fix issue where script fails if there is only a single entry * Bump version to resolve conflict * Add release-notes note * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Add types to outputs --------- Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Fix an issue where if all reputation values are '0', a null value is added to context.
Also migrate to Python, and update the logic to ignore '0' values in the calculation (after consulting @Ni-Knight).
Screenshots
Output before changes:
Output after changes:
