Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rplaced all realative with absulote paths #28057

Conversation

omerKarkKatz
Copy link
Contributor

@omerKarkKatz omerKarkKatz commented Jul 11, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

As part of the effort to support images in all products, we add support to images in description files.
As part of that, we had to first replace all image links to use URLs and not relative paths.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@github-actions
Copy link

Your contributed Lumu pack has been modified on files:

Packs/Lumu/Integrations/Lumu/Lumu_description.md
Please review the changes here

Packs/Lumu/ReleaseNotes/1_0_7.md Outdated Show resolved Hide resolved
Packs/Microsoft365Defender/ReleaseNotes/4_5_8.md Outdated Show resolved Hide resolved
Packs/SplunkPy/ReleaseNotes/3_0_23.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@thefrieddan1 Doc review completed.

omerKarkKatz and others added 3 commits July 11, 2023 19:27
doc review changes

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • SplunkPy pack version was bumped to 3.0.24.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@omerKarkKatz omerKarkKatz merged commit 3fa72ee into master Jul 13, 2023
13 of 14 checks passed
@omerKarkKatz omerKarkKatz deleted the replace_relative_to_absuloute_images_links_in_description_files branch July 13, 2023 09:09
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Rplaced all realative with absulote paths

* commit

* Apply suggestions from code review

doc review changes

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Bump pack from version SplunkPy to 3.0.24.

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Rplaced all realative with absulote paths

* commit

* Apply suggestions from code review

doc review changes

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Bump pack from version SplunkPy to 3.0.24.

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants