New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rplaced all realative with absulote paths #28057
Merged
omerKarkKatz
merged 6 commits into
master
from
replace_relative_to_absuloute_images_links_in_description_files
Jul 13, 2023
Merged
Rplaced all realative with absulote paths #28057
omerKarkKatz
merged 6 commits into
master
from
replace_relative_to_absuloute_images_links_in_description_files
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your contributed Lumu pack has been modified on files:Packs/Lumu/Integrations/Lumu/Lumu_description.md |
thefrieddan1
requested review from
ShirleyDenkberg
and removed request for
ilappe
July 11, 2023 14:15
@thefrieddan1 Doc review completed. |
doc review changes Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
thefrieddan1
approved these changes
Jul 12, 2023
…_in_description_files
omerKarkKatz
deleted the
replace_relative_to_absuloute_images_links_in_description_files
branch
July 13, 2023 09:09
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Rplaced all realative with absulote paths * commit * Apply suggestions from code review doc review changes Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Bump pack from version SplunkPy to 3.0.24. --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Rplaced all realative with absulote paths * commit * Apply suggestions from code review doc review changes Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Bump pack from version SplunkPy to 3.0.24. --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
As part of the effort to support images in all products, we add support to images in description files.
As part of that, we had to first replace all image links to use URLs and not relative paths.
Does it break backward compatibility?
Must have