Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD User to MISP #28100

Merged
merged 5 commits into from Jul 13, 2023
Merged

ADD User to MISP #28100

merged 5 commits into from Jul 13, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@yilmazdincer

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

I want to add a new user to misp, so I created a function called add_user_to_misp in the MISP integration.
Added three command:
-> misp-add-user
-> misp-get-organization-info
-> misp-get-role-info

Screenshots

image

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* Update .devcontainer.json name

* readme v4

* organisation ids and role ids

* Update 2_1_27.md

* Update 2_1_27.md

* readme

* flake8

* role and organization

* flake8

* editing

* editingv2

* readme

* editingv5

* password description

* editing v8

* revert and command_examples

* human readable

* all readme

* test

* test2

* test3

* test4

* outputs

* dict

* last editing

* formatting

* Test Playbook Verify

* verify is not empty

* output prefix

* editing validation and flake error

* master

* fixed test playbook

* fixed conflicts in the test playbook

* regenerate readme

* removed unnecessary file

* fixed test playbook and test_add_user_to_misp

* fixed trailing whitespaces

* fixed mypy errors

* pre commit

* pre commit

* fixes

---------

Co-authored-by: yilmazdincer <yilmazdincer@users.noreply.github.com>
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jul 12, 2023
@RotemAmit RotemAmit merged commit 9dc5919 into master Jul 13, 2023
14 checks passed
@RotemAmit RotemAmit deleted the contrib/yilmazdincer_misp_add_user branch July 13, 2023 09:17
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* ADD User to MISP (demisto#27410)

* Update .devcontainer.json name

* readme v4

* organisation ids and role ids

* Update 2_1_27.md

* Update 2_1_27.md

* readme

* flake8

* role and organization

* flake8

* editing

* editingv2

* readme

* editingv5

* password description

* editing v8

* revert and command_examples

* human readable

* all readme

* test

* test2

* test3

* test4

* outputs

* dict

* last editing

* formatting

* Test Playbook Verify

* verify is not empty

* output prefix

* editing validation and flake error

* master

* fixed test playbook

* fixed conflicts in the test playbook

* regenerate readme

* removed unnecessary file

* fixed test playbook and test_add_user_to_misp

* fixed trailing whitespaces

* fixed mypy errors

* pre commit

* pre commit

* fixes

---------

Co-authored-by: yilmazdincer <yilmazdincer@users.noreply.github.com>
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>

* fixed test playbook error

---------

Co-authored-by: yilmazdincer <58347888+yilmazdincer@users.noreply.github.com>
Co-authored-by: yilmazdincer <yilmazdincer@users.noreply.github.com>
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* ADD User to MISP (demisto#27410)

* Update .devcontainer.json name

* readme v4

* organisation ids and role ids

* Update 2_1_27.md

* Update 2_1_27.md

* readme

* flake8

* role and organization

* flake8

* editing

* editingv2

* readme

* editingv5

* password description

* editing v8

* revert and command_examples

* human readable

* all readme

* test

* test2

* test3

* test4

* outputs

* dict

* last editing

* formatting

* Test Playbook Verify

* verify is not empty

* output prefix

* editing validation and flake error

* master

* fixed test playbook

* fixed conflicts in the test playbook

* regenerate readme

* removed unnecessary file

* fixed test playbook and test_add_user_to_misp

* fixed trailing whitespaces

* fixed mypy errors

* pre commit

* pre commit

* fixes

---------

Co-authored-by: yilmazdincer <yilmazdincer@users.noreply.github.com>
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>

* fixed test playbook error

---------

Co-authored-by: yilmazdincer <58347888+yilmazdincer@users.noreply.github.com>
Co-authored-by: yilmazdincer <yilmazdincer@users.noreply.github.com>
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
4 participants