Fixing an issue in API metrics dashboard #28138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with JoeSecurity
thefrieddan1
requested review from
DeanArbel
and removed request for
michalgold and
idovandijk
|
@DeanArbel Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Fixing an issue in API metrics dashboard with JoeSecurity * fix Joe security IDs in API metrics dashboard. * Update Packs/CommonDashboards/ReleaseNotes/1_3_5.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * better RN phrasing * Update Packs/CommonDashboards/ReleaseNotes/1_3_5.md Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com> --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Fixing an issue in API metrics dashboard with JoeSecurity * fix Joe security IDs in API metrics dashboard. * Update Packs/CommonDashboards/ReleaseNotes/1_3_5.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * better RN phrasing * Update Packs/CommonDashboards/ReleaseNotes/1_3_5.md Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com> --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with JoeSecurity
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CRTX-87482
Description
Widget ID for joe security was off. Joe widget in API metrics hanged for ever in XSOAR8 and was shown as Cisco umbrella in XSOAR6.
Screenshots
This is the actual change. not sure why github is displaying the entire block as new. vscode is displaying just the relevant rows:
