Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDL] warn of updating with empty query #28144

Merged
merged 6 commits into from Jul 16, 2023
Merged

[EDL] warn of updating with empty query #28144

merged 6 commits into from Jul 16, 2023

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Jul 13, 2023 •
edited

@dorschw dorschw marked this pull request as ready for review July 13, 2023 15:07
MLainer1
MLainer1 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@MLainer1 MLainer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

yuvalbenshalom
yuvalbenshalom approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little fix

Packs/EDL/Integrations/EDL/EDL.py Outdated Show resolved Hide resolved
dorschw and others added 3 commits July 16, 2023 10:30
@dorschw dorschw merged commit b2e6588 into master Jul 16, 2023
13 of 14 checks passed
@dorschw dorschw deleted the ds-edl branch July 16, 2023 10:53
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
@dorschw @yuvalbenshalom @xsoar-bot
[EDL] warn of updating with empty query (demisto#28144)
d942e48 
* warn when updating with empty query

* bold warning

* autopep8

* Update Packs/EDL/Integrations/EDL/EDL.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* bump docker image

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
@dorschw @yuvalbenshalom @xsoar-bot
[EDL] warn of updating with empty query (demisto#28144)
8eb158f 
* warn when updating with empty query

* bold warning

* autopep8

* Update Packs/EDL/Integrations/EDL/EDL.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* bump docker image

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvalbenshalom yuvalbenshalom yuvalbenshalom approved these changes

@DeanArbel DeanArbel DeanArbel approved these changes

@MLainer1 MLainer1 MLainer1 approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
4 participants
@dorschw @yuvalbenshalom @DeanArbel @MLainer1