Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcp expandr 5021 #28195

Merged
merged 3 commits into from Jul 17, 2023
Merged

Gcp expandr 5021 #28195

merged 3 commits into from Jul 17, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@johnnywilkes

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-5021

Description

Before, the "!gcp-compute-aggregated-list-instances-by-ip" command would error out unless if found a VM with the appropriate IP. We want to change this to just display a message instead to not hold playbook progress.

Screenshots

image

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* Update command to return CommandResults with message, instead of throwing an error
* Upated RNs
* Updated docker image

---------

Co-authored-by: Anas Yousef <44998563+anas-yousef@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jul 16, 2023
@anas-yousef anas-yousef merged commit 055205e into master Jul 17, 2023
15 of 16 checks passed
@anas-yousef anas-yousef deleted the contrib/johnnywilkes_GCP-EXPANDR-5021 branch July 17, 2023 11:56
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Update command to return CommandResults with message, instead of throwing an error
* Upated RNs
* Updated docker image
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Update command to return CommandResults with message, instead of throwing an error
* Upated RNs
* Updated docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
3 participants