Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYAS Insight hash endpoints #28357

Merged
merged 7 commits into from Aug 17, 2023

Conversation

RamboV
Copy link
Contributor

@RamboV RamboV commented Jul 20, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jul 20, 2023
@content-bot content-bot changed the base branch from master to contrib/hyasinfosec_hyasinsight July 20, 2023 12:56
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Jul 20, 2023
@kgal-pan
Copy link
Contributor

Actual Partner ID is hyas-infosec-8878.

@RamboV
Copy link
Contributor Author

RamboV commented Jul 24, 2023

Actual Partner ID is hyas-infosec-8878.

Do I need to reopen new PR?

@kgal-pan kgal-pan reopened this Jul 24, 2023
@mmhw
Copy link
Contributor

mmhw commented Jul 24, 2023

It was closed due to a bug with us, we will reopen it as soon as the bug is fixed

@kgal-pan
Copy link
Contributor

Actual Partner ID is hyas-infosec-8878.

Do I need to reopen new PR?

No need, keep it in mind for next PR you open.

@mmhw mmhw removed the stale-branch label Jul 24, 2023
@RamboV
Copy link
Contributor Author

RamboV commented Jul 24, 2023

Actual Partner ID is hyas-infosec-8878.

Do I need to reopen new PR?

No need, keep it in mind for next PR you open.

Ok Thanks

Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RamboV ,
Thank you for your contribution!
Good work :)

Please note my small comments!

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

Packs/HYASInsight/Integrations/HYASInsight/HYASInsight.py Outdated Show resolved Hide resolved
Packs/HYASInsight/ReleaseNotes/1_1_0.md Outdated Show resolved Hide resolved
@mmhw mmhw added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 25, 2023
@content-bot
Copy link
Collaborator

content-bot commented Jul 25, 2023

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5872554

@RamboV RamboV requested a review from GuyAfik as a code owner July 26, 2023 06:39
@mmhw mmhw removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 26, 2023
@mmhw mmhw added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 26, 2023
@mmhw
Copy link
Contributor

mmhw commented Jul 26, 2023

Hi @RamboV, the code looks good!

We're ready for a demo.
Please check this page, and let me know when you're available for one over the Slack or you can send me a video with a demo of the new commands you added.

@mmhw mmhw added pending-demo Demo pending and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jul 30, 2023
@mmhw
Copy link
Contributor

mmhw commented Aug 10, 2023

Hi @RamboV,
Thank you for your contribution.
I have not received a response from you in the last two weeks, do you need help with something?

Thanks again.

Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mmhw mmhw merged commit 0e28d13 into demisto:contrib/hyasinfosec_hyasinsight Aug 17, 2023
11 of 19 checks passed
@content-bot content-bot mentioned this pull request Aug 17, 2023
5 tasks
mmhw added a commit that referenced this pull request Aug 17, 2023
* HYAS Insight hash endpoints (#28357)

* New commands added

* release note added

* Added commands to release note

* added secrets to .secrete-ignore file

* change param hash->sha1 in ssl certificate command

* Update the docker images; Run pre-commit

* Fix mypy error

---------

Co-authored-by: Rambatla Venkat Rao <68921481+RamboV@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
TalNos pushed a commit that referenced this pull request Aug 20, 2023
* HYAS Insight hash endpoints (#28357)

* New commands added

* release note added

* Added commands to release note

* added secrets to .secrete-ignore file

* change param hash->sha1 in ssl certificate command

* Update the docker images; Run pre-commit

* Fix mypy error

---------

Co-authored-by: Rambatla Venkat Rao <68921481+RamboV@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* HYAS Insight hash endpoints (demisto#28357)

* New commands added

* release note added

* Added commands to release note

* added secrets to .secrete-ignore file

* change param hash->sha1 in ssl certificate command

* Update the docker images; Run pre-commit

* Fix mypy error

---------

Co-authored-by: Rambatla Venkat Rao <68921481+RamboV@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* HYAS Insight hash endpoints (#28357)

* New commands added

* release note added

* Added commands to release note

* added secrets to .secrete-ignore file

* change param hash->sha1 in ssl certificate command

* Update the docker images; Run pre-commit

* Fix mypy error

---------

Co-authored-by: Rambatla Venkat Rao <68921481+RamboV@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner pending-demo Demo pending Security Review
Projects
None yet
5 participants