Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xsup 26348/feed misp ip type #28361

Merged
merged 7 commits into from Jul 21, 2023
Merged

Conversation

MosheEichler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-26348

Description

Fixed an issue with recognizing an indicator of type CIDR as IP.

Must have

  • Tests
  • Documentation

@ShirleyDenkberg
Copy link
Contributor

@DeanArbel @bziser Doc review completed. Looks good.

@MosheEichler MosheEichler marked this pull request as ready for review July 20, 2023 14:58
https://x.x.x.x
2001:0db8:85a3:0000:0000:8a2e:0370:7334
2001:0db8:85a3:0000:0000:8a2e:0370:7334/64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@MosheEichler MosheEichler merged commit 824dc4f into master Jul 21, 2023
14 checks passed
@MosheEichler MosheEichler deleted the XSUP-26348/feed_misp_ip_type branch July 21, 2023 03:15
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* fixed find IP type

* RN

* mypy fixes

* docker

* ignore secrets
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* fixed find IP type

* RN

* mypy fixes

* docker

* ignore secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants