Analyst1 202306 Updates #28418
Merged
Analyst1 202306 Updates #28418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Analyst1 202306 Updates Updates to XSOAR app to work with Analyst1 2.1 and other APIs previously released * Formatting & Feedback Redressing multiple formatting and initial PR feedback. More to follow for code coverage and images. * Unit Testing Coverage New unit tests for all new functions * YML/PY Fixes and Commands Examples Found errors in consistency. Including commands example txt. * Secrets Fix Removed IP address that caused "Secrets" failure. * Secrets Fix Actual secrets fix and removing invalid file from last commit. * README and Testing Fixes README contains placeholders for all new functions. Additional testing fixes to remove Flake8 and Vulture errors. * Update Analyst1_image.png Fixed the image to comply with expectations. * Additional command name fixes revert analyst1-enrich-url to url per PR note * Fix unexpected execution path in batch check post In final testing, found that a certain way inputs could come in would confuse the previously tested logic. So had to allow for some gracious processing of possible STR input to this scenario. * Removed Secrets * Redress Most MyPy Errors * Resolved "return_error" being called too often & reversed illuminate.py * Images correct dimensions * increase test coverage * Update Packs/illuminate/ReleaseNotes/1_1_0.md * Update Packs/illuminate/Integrations/Analyst1/Analyst1.yml * MyPy resolution after testing Also closing a file which was opened as a best practice. * Formatting changes to resolve IN135 Update Packs/illuminate/Integrations/Analyst1/Analyst1.yml Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> * Docker Image [2023-07-17 12:37:19,845] [ERROR] Packs/illuminate/Integrations/Analyst1/Analyst1.yml: [DO106] - The docker image tag is not the latest numeric tag, please update it. The docker image tag in the yml file is: 3.10.11.61265 The latest docker image tag in docker hub is: 3.10.12.63474 * Apply suggestions from code review * Update the docker image * pre-commit * pre-commit on test file --------- Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
content-bot
added
Contribution
mmhw
approved these changes
Jul 23, 2023
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Analyst1 202306 Updates Updates to XSOAR app to work with Analyst1 2.1 and other APIs previously released * Formatting & Feedback Redressing multiple formatting and initial PR feedback. More to follow for code coverage and images. * Unit Testing Coverage New unit tests for all new functions * YML/PY Fixes and Commands Examples Found errors in consistency. Including commands example txt. * Secrets Fix Removed IP address that caused "Secrets" failure. * Secrets Fix Actual secrets fix and removing invalid file from last commit. * README and Testing Fixes README contains placeholders for all new functions. Additional testing fixes to remove Flake8 and Vulture errors. * Update Analyst1_image.png Fixed the image to comply with expectations. * Additional command name fixes revert analyst1-enrich-url to url per PR note * Fix unexpected execution path in batch check post In final testing, found that a certain way inputs could come in would confuse the previously tested logic. So had to allow for some gracious processing of possible STR input to this scenario. * Removed Secrets * Redress Most MyPy Errors * Resolved "return_error" being called too often & reversed illuminate.py * Images correct dimensions * increase test coverage * Update Packs/illuminate/ReleaseNotes/1_1_0.md * Update Packs/illuminate/Integrations/Analyst1/Analyst1.yml * MyPy resolution after testing Also closing a file which was opened as a best practice. * Formatting changes to resolve IN135 Update Packs/illuminate/Integrations/Analyst1/Analyst1.yml * Docker Image [2023-07-17 12:37:19,845] [ERROR] Packs/illuminate/Integrations/Analyst1/Analyst1.yml: [DO106] - The docker image tag is not the latest numeric tag, please update it. The docker image tag in the yml file is: 3.10.11.61265 The latest docker image tag in docker hub is: 3.10.12.63474 * Apply suggestions from code review * Update the docker image * pre-commit * pre-commit on test file --------- Co-authored-by: a1-james <137313186+a1-james@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* Analyst1 202306 Updates Updates to XSOAR app to work with Analyst1 2.1 and other APIs previously released * Formatting & Feedback Redressing multiple formatting and initial PR feedback. More to follow for code coverage and images. * Unit Testing Coverage New unit tests for all new functions * YML/PY Fixes and Commands Examples Found errors in consistency. Including commands example txt. * Secrets Fix Removed IP address that caused "Secrets" failure. * Secrets Fix Actual secrets fix and removing invalid file from last commit. * README and Testing Fixes README contains placeholders for all new functions. Additional testing fixes to remove Flake8 and Vulture errors. * Update Analyst1_image.png Fixed the image to comply with expectations. * Additional command name fixes revert analyst1-enrich-url to url per PR note * Fix unexpected execution path in batch check post In final testing, found that a certain way inputs could come in would confuse the previously tested logic. So had to allow for some gracious processing of possible STR input to this scenario. * Removed Secrets * Redress Most MyPy Errors * Resolved "return_error" being called too often & reversed illuminate.py * Images correct dimensions * increase test coverage * Update Packs/illuminate/ReleaseNotes/1_1_0.md * Update Packs/illuminate/Integrations/Analyst1/Analyst1.yml * MyPy resolution after testing Also closing a file which was opened as a best practice. * Formatting changes to resolve IN135 Update Packs/illuminate/Integrations/Analyst1/Analyst1.yml * Docker Image [2023-07-17 12:37:19,845] [ERROR] Packs/illuminate/Integrations/Analyst1/Analyst1.yml: [DO106] - The docker image tag is not the latest numeric tag, please update it. The docker image tag in the yml file is: 3.10.11.61265 The latest docker image tag in docker hub is: 3.10.12.63474 * Apply suggestions from code review * Update the docker image * pre-commit * pre-commit on test file --------- Co-authored-by: a1-james <137313186+a1-james@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@a1-james
Updates to XSOAR app to work with Analyst1 2.1 and other APIs previously released
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have