Workday bug #28490
Merged
Workday bug #28490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanArbel
reviewed
Jul 25, 2023
| @@ -0,0 +1 @@ | |||
| {"breakingChanges":true,"breakingChangesNotes":"Updated the dataset name of the Workday Collector."} | |||
There was a problem hiding this comment.
Please add an explanation that new events will be collected to the new dataset.
DeanArbel
requested changes
Jul 25, 2023
There was a problem hiding this comment.
@merit-maita You should also update the python code, where the vendor+brand sets the name for the dataset, please make sure it creates the expected data set
|
as seen in this screenshot, the dataset was set correctly to "workday_activity_raw"
|
DeanArbel
approved these changes
Jul 26, 2023
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* changed the dataset name of workday collector * added release notes * Revert "changed the dataset name of workday collector" This reverts commit df0b8c9. * Revert "added release notes" This reverts commit 458e505. * chagned dataset name * added rn * edited rn * edited rn * edited rn * updated the name according to what was decided. * edited the name in py code * updated docker image * fixed a minor code issue * change for pre-commit * change for pre-commit * change for pre-commit
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* changed the dataset name of workday collector * added release notes * Revert "changed the dataset name of workday collector" This reverts commit df0b8c9. * Revert "added release notes" This reverts commit 458e505. * chagned dataset name * added rn * edited rn * edited rn * edited rn * updated the name according to what was decided. * edited the name in py code * updated docker image * fixed a minor code issue * change for pre-commit * change for pre-commit * change for pre-commit
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* changed the dataset name of workday collector * added release notes * Revert "changed the dataset name of workday collector" This reverts commit df0b8c9. * Revert "added release notes" This reverts commit 458e505. * chagned dataset name * added rn * edited rn * edited rn * edited rn * updated the name according to what was decided. * edited the name in py code * updated docker image * fixed a minor code issue * change for pre-commit * change for pre-commit * change for pre-commit
ostolero
pushed a commit
that referenced
this pull request
Aug 8, 2023
* changed the dataset name of workday collector * added release notes * Revert "changed the dataset name of workday collector" This reverts commit df0b8c9. * Revert "added release notes" This reverts commit 458e505. * chagned dataset name * added rn * edited rn * edited rn * edited rn * updated the name according to what was decided. * edited the name in py code * updated docker image * fixed a minor code issue * change for pre-commit * change for pre-commit * change for pre-commit
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* changed the dataset name of workday collector * added release notes * Revert "changed the dataset name of workday collector" This reverts commit df0b8c9. * Revert "added release notes" This reverts commit 458e505. * chagned dataset name * added rn * edited rn * edited rn * edited rn * updated the name according to what was decided. * edited the name in py code * updated docker image * fixed a minor code issue * change for pre-commit * change for pre-commit * change for pre-commit
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* changed the dataset name of workday collector * added release notes * Revert "changed the dataset name of workday collector" This reverts commit b7e0df23c78b68a6dc7c518290433954009bfd7c. * Revert "added release notes" This reverts commit 57fb0f48118cb6a627c18fcc8a6956b87e7637f3. * chagned dataset name * added rn * edited rn * edited rn * edited rn * updated the name according to what was decided. * edited the name in py code * updated docker image * fixed a minor code issue * change for pre-commit * change for pre-commit * change for pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-25251
Description
changed the dataset name of the workday collector.
Must have