Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - Expander - Ev2.2 Api Updates #28491

Merged
merged 4 commits into from Jul 26, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@andrew-paloalto

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-3268
https://jira-hq.paloaltonetworks.local/browse/EXPANDR-4835

Description

Adding several new command and capabilities based on new APIs released in Expander 2.2.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* API Updates batch 1

* validation errors

* Release Notes

* README

* incident field validation

* context output updates

* initial test set

* fix failing tests

* all tag tests

* fix tests

* test fix

* fix fetch incident test

* validation errors

* release notes

* test fix

* adding last tests

* expected results

* mock path

* test result

* test result2

* expected result

* release notes style

* add additional alert list args

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update integration readme and added layout updates

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix failing ASR param

* address ASR command params

* Add BU field

* rename command

* add known words

* remove update alert command pending an API bug fix

* Predefined values for manual severity

* docker version

* clarify tag usage documentation

* Handle tags that don't exist

* Handle tags error

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jul 25, 2023
@content-bot content-bot requested a review from mmhw July 25, 2023 13:23
Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mmhw mmhw merged commit 021b186 into master Jul 26, 2023
14 checks passed
@mmhw mmhw deleted the contrib/andrew-paloalto_Ev2.2_API_updates branch July 26, 2023 10:58
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* [ASM] - Expander - Ev2.2 Api Updates (demisto#27824)

* API Updates batch 1

* validation errors

* Release Notes

* README

* incident field validation

* context output updates

* initial test set

* fix failing tests

* all tag tests

* fix tests

* test fix

* fix fetch incident test

* validation errors

* release notes

* test fix

* adding last tests

* expected results

* mock path

* test result

* test result2

* expected result

* release notes style

* add additional alert list args

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update integration readme and added layout updates

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix failing ASR param

* address ASR command params

* Add BU field

* rename command

* add known words

* remove update alert command pending an API bug fix

* Predefined values for manual severity

* docker version

* clarify tag usage documentation

* Handle tags that don't exist

* Handle tags error

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update the docker image

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* [ASM] - Expander - Ev2.2 Api Updates (demisto#27824)

* API Updates batch 1

* validation errors

* Release Notes

* README

* incident field validation

* context output updates

* initial test set

* fix failing tests

* all tag tests

* fix tests

* test fix

* fix fetch incident test

* validation errors

* release notes

* test fix

* adding last tests

* expected results

* mock path

* test result

* test result2

* expected result

* release notes style

* add additional alert list args

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update integration readme and added layout updates

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix failing ASR param

* address ASR command params

* Add BU field

* rename command

* add known words

* remove update alert command pending an API bug fix

* Predefined values for manual severity

* docker version

* clarify tag usage documentation

* Handle tags that don't exist

* Handle tags error

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update the docker image

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* [ASM] - Expander - Ev2.2 Api Updates (demisto#27824)

* API Updates batch 1

* validation errors

* Release Notes

* README

* incident field validation

* context output updates

* initial test set

* fix failing tests

* all tag tests

* fix tests

* test fix

* fix fetch incident test

* validation errors

* release notes

* test fix

* adding last tests

* expected results

* mock path

* test result

* test result2

* expected result

* release notes style

* add additional alert list args

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update integration readme and added layout updates

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix failing ASR param

* address ASR command params

* Add BU field

* rename command

* add known words

* remove update alert command pending an API bug fix

* Predefined values for manual severity

* docker version

* clarify tag usage documentation

* Handle tags that don't exist

* Handle tags error

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update the docker image

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
ostolero pushed a commit that referenced this pull request Aug 8, 2023
* [ASM] - Expander - Ev2.2 Api Updates (#27824)

* API Updates batch 1

* validation errors

* Release Notes

* README

* incident field validation

* context output updates

* initial test set

* fix failing tests

* all tag tests

* fix tests

* test fix

* fix fetch incident test

* validation errors

* release notes

* test fix

* adding last tests

* expected results

* mock path

* test result

* test result2

* expected result

* release notes style

* add additional alert list args

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update integration readme and added layout updates

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix failing ASR param

* address ASR command params

* Add BU field

* rename command

* add known words

* remove update alert command pending an API bug fix

* Predefined values for manual severity

* docker version

* clarify tag usage documentation

* Handle tags that don't exist

* Handle tags error

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update the docker image

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* [ASM] - Expander - Ev2.2 Api Updates (demisto#27824)

* API Updates batch 1

* validation errors

* Release Notes

* README

* incident field validation

* context output updates

* initial test set

* fix failing tests

* all tag tests

* fix tests

* test fix

* fix fetch incident test

* validation errors

* release notes

* test fix

* adding last tests

* expected results

* mock path

* test result

* test result2

* expected result

* release notes style

* add additional alert list args

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update integration readme and added layout updates

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix failing ASR param

* address ASR command params

* Add BU field

* rename command

* add known words

* remove update alert command pending an API bug fix

* Predefined values for manual severity

* docker version

* clarify tag usage documentation

* Handle tags that don't exist

* Handle tags error

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update the docker image

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* [ASM] - Expander - Ev2.2 Api Updates (#27824)

* API Updates batch 1

* validation errors

* Release Notes

* README

* incident field validation

* context output updates

* initial test set

* fix failing tests

* all tag tests

* fix tests

* test fix

* fix fetch incident test

* validation errors

* release notes

* test fix

* adding last tests

* expected results

* mock path

* test result

* test result2

* expected result

* release notes style

* add additional alert list args

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update integration readme and added layout updates

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix failing ASR param

* address ASR command params

* Add BU field

* rename command

* add known words

* remove update alert command pending an API bug fix

* Predefined values for manual severity

* docker version

* clarify tag usage documentation

* Handle tags that don't exist

* Handle tags error

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update the docker image

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>
Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
3 participants