[Marketplace Contribution] AWS - IAM Identity Center #28559

xsoar-bot · 2023-07-27T10:47:16Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

Description

AWS IAM Identity Center

Author: Sameh El-Hakim

With AWS IAM Identity Center (successor to AWS Single Sign-On), you can manage sign-in security for your workforce identities, also known as workforce users. IAM Identity Center provides one place where you can create or connect workforce users and manage their access centrally across all their AWS accounts and applications. IAM Identity Center is the recommended approach for workforce authentication and authorization in AWS, for organizations of any size and type.

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

content-bot · 2023-07-27T10:49:34Z

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @anas-yousef will very shortly look over your proposed changes.

anas-yousef · 2023-07-30T20:18:56Z

Packs/ApiModules/Scripts/AWSApiModule/AWSApiModule.py

@@ -190,4 +191,4 @@ def get_timeout(timeout):
            raise DemistoException("You can specify just the read timeout (for example 60) or also the connect "
                                   "timeout followed after a comma (for example 60,10). If a connect timeout is not "
                                   "specified, a default of 10 second will be used.")
-        return read_timeout, connect_timeout
+        return read_timeout, connect_timeout


Was this change made by mistake?

I didn't change that pack maybe something happened while submitting my pack

anas-yousef · 2023-07-30T20:23:54Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+        ],
+        DisplayName=f'{userDisplayName}'
+    )
+    print(response)


Don't forget to remove the print function.

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

anas-yousef · 2023-07-30T20:33:56Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+            remove_user_from_groups(args, client)
+
+    except Exception as e:
+        LOG(str(e))


return_error returns the LOG object with the error, no need to call it here

Suggested change

LOG(str(e))

anas-yousef · 2023-07-30T20:34:27Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+if __name__ in ('__builtin__', 'builtins', '__main__'):
+    main()
+
+register_module_line('AWS - IAM Identity Cetner', 'end', __line__())


Suggested change

register_module_line('AWS - IAM Identity Cetner', 'end', __line__())

anas-yousef · 2023-07-30T20:37:24Z

...AMIdentityCenter/Integrations/AWSIAMIdentityCenter/integration-AWS_-_IAM_Identity_Center.yml

Don't forget to delete this file

anas-yousef · 2023-07-30T20:39:46Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/README.md

Please add a README file for the integration. You can use the documentation found here to do that.

anas-yousef · 2023-08-06T15:37:39Z

Hey @sepaprivate,
Thank you for your contribution!
Take a look at the comments that I added. Please update me if you have any questions here or over the DFIR slack channel

…AWSIAMIdentityCenter.py Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

Fixing couple of issues

sepaprivate · 2023-08-14T09:44:52Z

Hi @anas-yousef any update on this pack?

anas-yousef · 2023-08-14T16:07:01Z

Hello @sepaprivate, I saw that you added new changes. I am currently going over them

anas-yousef · 2023-08-14T16:08:43Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+#def update_user(args, client):  # pragma: no cover
+#    kwargs = {'UserName': args.get('oldUserName')}
+#    if args.get('newUserName'):
+#        kwargs.update({'NewUserName': args.get('newUserName')})
+#    if args.get('newPath'):
+#        kwargs.update({'NewPath': args.get('newPath')})
+#
+#    response = client.update_user(**kwargs)
+#    if response['ResponseMetadata']['HTTPStatusCode'] == 200:
+#        demisto.results(
+#            "Changed UserName {0} To: {1}".format(args.get('oldUserName'), args.get('newUserName')))
+
+
+#def delete_user(args, client):  # pragma: no cover
+#    response = client.delete_user(UserName=args.get('userName'))
+#    if response['ResponseMetadata']['HTTPStatusCode'] == 200:
+#        demisto.results('The User {0} has been deleted'.format(args.get('userName')))


Are these needed? If not, please delete them

anas-yousef · 2023-08-14T16:11:09Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+
+        if role_policy is not None:
+            kwargs.update({'Policy': role_policy})
+        elif self.aws_role_policy is not None:
+            kwargs.update({'Policy': self.aws_role_policy})
+
+        demisto.debug('{kwargs}='.format(kwargs=kwargs))
+
+        if kwargs and not self.aws_access_key_id:  # login with Role ARN
+            if not self.aws_access_key_id:
+                sts_client = boto3.client('sts', config=self.config, verify=self.verify_certificate,
+                                          region_name=region if region else self.aws_default_region,
+                                          endpoint_url=self.sts_endpoint_url)
+                sts_response = sts_client.assume_role(**kwargs)
+                client = boto3.client(
+                    service_name=service,
+                    region_name=region if region else self.aws_default_region,
+                    aws_access_key_id=sts_response['Credentials']['AccessKeyId'],
+                    aws_secret_access_key=sts_response['Credentials']['SecretAccessKey'],
+                    aws_session_token=sts_response['Credentials']['SessionToken'],
+                    verify=self.verify_certificate,
+                    config=self.config,
+                    endpoint_url=self.endpoint_url
+                )
+        elif self.aws_access_key_id and (role_arn or self.aws_role_arn):  # login with Access Key ID and Role ARN
+            sts_client = boto3.client(
+                service_name='sts',
+                aws_access_key_id=self.aws_access_key_id,
+                aws_secret_access_key=self.aws_secret_access_key,
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.sts_endpoint_url
+            )
+            kwargs.update({
+                'RoleArn': role_arn or self.aws_role_arn,
+                'RoleSessionName': role_session_name or self.aws_role_session_name,
+            })
+            sts_response = sts_client.assume_role(**kwargs)
+            client = boto3.client(
+                service_name=service,
+                region_name=region if region else self.aws_default_region,
+                aws_access_key_id=sts_response['Credentials']['AccessKeyId'],
+                aws_secret_access_key=sts_response['Credentials']['SecretAccessKey'],
+                aws_session_token=sts_response['Credentials']['SessionToken'],
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.endpoint_url
+            )
+        elif self.aws_session_token and not self.aws_role_arn:  # login with session token
+            client = boto3.client(
+                service_name=service,
+                region_name=region if region else self.aws_default_region,
+                aws_access_key_id=self.aws_access_key_id,
+                aws_secret_access_key=self.aws_secret_access_key,
+                aws_session_token=self.aws_session_token,
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.endpoint_url
+            )
+        elif self.aws_access_key_id and not self.aws_role_arn:  # login with access key id
+            client = boto3.client(
+                service_name=service,
+                region_name=region if region else self.aws_default_region,
+                aws_access_key_id=self.aws_access_key_id,
+                aws_secret_access_key=self.aws_secret_access_key,
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.endpoint_url
+            )
+        else:  # login with default permissions, permissions pulled from the ec2 metadata
+            client = boto3.client(service_name=service,
+                                  region_name=region if region else self.aws_default_region,
+                                  endpoint_url=self.endpoint_url)
+
+        return client
+
+    @staticmethod
+    def get_timeout(timeout):
+        if not timeout:
+            timeout = "60,10"  # default values
+        try:
+
+            if isinstance(timeout, int):
+                read_timeout = timeout
+                connect_timeout = 10
+
+            else:
+                timeout_vals = timeout.split(',')
+                read_timeout = int(timeout_vals[0])
+                # the default connect timeout is 10
+                connect_timeout = 10 if len(timeout_vals) == 1 else int(timeout_vals[1])
+
+        except ValueError:
+            raise DemistoException("You can specify just the read timeout (for example 60) or also the connect "
+                                   "timeout followed after a comma (for example 60,10). If a connect timeout is not "
+                                   "specified, a default of 10 second will be used.")
+        return read_timeout, connect_timeout
+
+register_module_line('AWSApiModule', 'end', __line__(), wrapper=1)
+### END GENERATED CODE ###


I believe this was added by accident? I'll remove it

No, it is reauired

anas-yousef · 2023-08-14T16:36:41Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+from CommonServerPython import *  # noqa: F401
+
+
+import botocore.exceptions


Is this used?

Yes botocore is essential for AWS authentication and other methods

anas-yousef · 2023-08-14T16:37:34Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+# def update_user(args, client):  # pragma: no cover
+#    kwargs = {'UserName': args.get('oldUserName')}
+#    if args.get('newUserName'):
+#        kwargs.update({'NewUserName': args.get('newUserName')})
+#    if args.get('newPath'):
+#        kwargs.update({'NewPath': args.get('newPath')})
+#
+#    response = client.update_user(**kwargs)
+#    if response['ResponseMetadata']['HTTPStatusCode'] == 200:
+#        demisto.results(
+#            "Changed UserName {0} To: {1}".format(args.get('oldUserName'), args.get('newUserName')))
+
+
+# def delete_user(args, client):  # pragma: no cover
+#    response = client.delete_user(UserName=args.get('userName'))
+#    if response['ResponseMetadata']['HTTPStatusCode'] == 200:
+#        demisto.results('The User {0} has been deleted'.format(args.get('userName')))


Is this needed? If not, please delete it.

anas-yousef · 2023-08-14T16:38:42Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.yml

+    - name: familyName
+    - name: givenName
+      required: true
+    - name: userEmailAddress
+      required: true
+    - name: displayName
+      required: true


Add descriptions for these arguments.

anas-yousef · 2023-08-14T16:39:16Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.yml

+    description: Adds the specified user to the specified group.
+    name: aws-iam-identitycenter-add-user-to-group
+  - arguments:
+    - name: groupName


Add a description here for this argument

anas-yousef · 2023-08-14T16:40:11Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.yml

+    description: This will remove the entered user from all groups/memberships.
+    name: aws-iam-identitycenter-remove-user-from-all-groups
+  - arguments:
+    - name: emailAddress


Add a description here for this argument

anas-yousef · 2023-08-14T16:40:52Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/README.md

Once you update the yml file, I will update the README to reflect the latest changes.

@anas-yousef all required changes are done, for your review please!

Remove commented functions

Adding Required Descriptions to arguments

…tyCenter' into sepaprivate-contrib-AWS-IAMIdentityCenter

anas-yousef

Add the description of the outputs that I mentioned, and let us talk over Slack so we can set up time for a demo :)

anas-yousef · 2023-08-23T08:32:32Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.yml

+    - contextPath: AWS.IAM.IdentityCenter.Users.UserName
+      type: string
+    - contextPath: AWS.IAM.IdentityCenter.Users.Email
+      type: string
+    - contextPath: AWS.IAM.IdentityCenter.Users.UserId
+      type: string
+    - contextPath: AWS.IAM.IdentityCenter.Users.DisplayName
+      type: string


Please add descriptions for these outputs

anas-yousef

Hey @sepaprivate,
I reviewed your demo and everything looks good. I added some small comments. Take a look at them whenever you can.
Address the errors in the yml file.

anas-yousef · 2023-09-13T07:38:08Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+        elif command == 'aws-iam-identitycenter-get-group':
+            get_user(args, client)


Is this the correct method for the command aws-iam-identitycenter-get-group?

Good catch thank you, I fixed it

anas-yousef · 2023-09-13T07:43:50Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+                'Email': user['Emails'][0]['Value'],
+                'DisplayName': user['DisplayName']
+            }
+            userID = user['UserId']


Is there a reason you only take the last UserId, since multiple users can be returned?

Actually, there will be always one user returned not multiple. I'm fetching list of users from AWS then looping on that list to check if the queried user is available or not. So, always one userId will be returned so i can use it in listing group assigned to that user later on.

Fix issues

Modified couple of functions, and removed unnecessary function (Date) added the AmazonAPIModule as the import didn't work

Fix some formatting

Add missing description fields

Fixing missing fields and updating tag for boto3py3 docker image

sepaprivate · 2023-09-13T12:42:53Z

@anas-yousef all issues have been fixed. Thank you

Post Fixes

Changes in Parameter Configurations

sepaprivate · 2023-09-17T08:46:39Z

Hi @anas-yousef, the integration is now fully updated. Please for your review.

…tyCenter' into sepaprivate-contrib-AWS-IAMIdentityCenter

Updating Docker image tag to latest version

anas-yousef · 2023-09-18T08:36:55Z

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

+
+        if role_policy is not None:
+            kwargs.update({'Policy': role_policy})
+        elif self.aws_role_policy is not None:
+            kwargs.update({'Policy': self.aws_role_policy})
+
+        demisto.debug('{kwargs}='.format(kwargs=kwargs))
+
+        if kwargs and not self.aws_access_key_id:  # login with Role ARN
+            if not self.aws_access_key_id:
+                sts_client = boto3.client('sts', config=self.config, verify=self.verify_certificate,
+                                          region_name=region if region else self.aws_default_region,
+                                          endpoint_url=self.sts_endpoint_url)
+                sts_response = sts_client.assume_role(**kwargs)
+                client = boto3.client(
+                    service_name=service,
+                    region_name=region if region else self.aws_default_region,
+                    aws_access_key_id=sts_response['Credentials']['AccessKeyId'],
+                    aws_secret_access_key=sts_response['Credentials']['SecretAccessKey'],
+                    aws_session_token=sts_response['Credentials']['SessionToken'],
+                    verify=self.verify_certificate,
+                    config=self.config,
+                    endpoint_url=self.endpoint_url
+                )
+        elif self.aws_access_key_id and (role_arn or self.aws_role_arn):  # login with Access Key ID and Role ARN
+            sts_client = boto3.client(
+                service_name='sts',
+                aws_access_key_id=self.aws_access_key_id,
+                aws_secret_access_key=self.aws_secret_access_key,
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.sts_endpoint_url
+            )
+            kwargs.update({
+                'RoleArn': role_arn or self.aws_role_arn,
+                'RoleSessionName': role_session_name or self.aws_role_session_name,
+            })
+            sts_response = sts_client.assume_role(**kwargs)
+            client = boto3.client(
+                service_name=service,
+                region_name=region if region else self.aws_default_region,
+                aws_access_key_id=sts_response['Credentials']['AccessKeyId'],
+                aws_secret_access_key=sts_response['Credentials']['SecretAccessKey'],
+                aws_session_token=sts_response['Credentials']['SessionToken'],
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.endpoint_url
+            )
+        elif self.aws_session_token and not self.aws_role_arn:  # login with session token
+            client = boto3.client(
+                service_name=service,
+                region_name=region if region else self.aws_default_region,
+                aws_access_key_id=self.aws_access_key_id,
+                aws_secret_access_key=self.aws_secret_access_key,
+                aws_session_token=self.aws_session_token,
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.endpoint_url
+            )
+        elif self.aws_access_key_id and not self.aws_role_arn:  # login with access key id
+            client = boto3.client(
+                service_name=service,
+                region_name=region if region else self.aws_default_region,
+                aws_access_key_id=self.aws_access_key_id,
+                aws_secret_access_key=self.aws_secret_access_key,
+                verify=self.verify_certificate,
+                config=self.config,
+                endpoint_url=self.endpoint_url
+            )
+        else:  # login with default permissions, permissions pulled from the ec2 metadata
+            client = boto3.client(service_name=service,
+                                  region_name=region if region else self.aws_default_region,
+                                  endpoint_url=self.endpoint_url)
+
+        return client
+
+    @staticmethod
+    def get_timeout(timeout):
+        if not timeout:
+            timeout = "60,10"  # default values
+        try:
+
+            if isinstance(timeout, int):
+                read_timeout = timeout
+                connect_timeout = 10
+
+            else:
+                timeout_vals = timeout.split(',')
+                read_timeout = int(timeout_vals[0])
+                # the default connect timeout is 10
+                connect_timeout = 10 if len(timeout_vals) == 1 else int(timeout_vals[1])
+
+        except ValueError:
+            raise DemistoException("You can specify just the read timeout (for example 60) or also the connect "
+                                   "timeout followed after a comma (for example 60,10). If a connect timeout is not "
+                                   "specified, a default of 10 second will be used.")
+        return read_timeout, connect_timeout
+
+register_module_line('AWSApiModule', 'end', __line__(), wrapper=1)
+### END GENERATED CODE ###


Delete the generated code, this is not needed.

@anas-yousef Done

Remove generated code

…tyCenter' into sepaprivate-contrib-AWS-IAMIdentityCenter

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py

…AWSIAMIdentityCenter.py Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

content-bot · 2023-09-19T13:00:35Z

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6364492

* [Marketplace Contribution] AWS - IAM Identity Center (#28559) * Update Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py * Update AWSIAMIdentityCenter.pyl * Update pack_metadata.json * Update AWSIAMIdentityCenter_description.md * Update AWSIAMIdentityCenter.ymll * Delete generated API module * Removed unnecessary package --------- Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> * Update AWSIAMIdentityCenter.yml * Update README.md * Update README.md * Fixed Pack README --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

* [Marketplace Contribution] AWS - IAM Identity Center (demisto#28559) * Update Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py * Update AWSIAMIdentityCenter.pyl * Update pack_metadata.json * Update AWSIAMIdentityCenter_description.md * Update AWSIAMIdentityCenter.ymll * Delete generated API module * Removed unnecessary package --------- Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> * Update AWSIAMIdentityCenter.yml * Update README.md * Update README.md * Fixed Pack README --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

* [Marketplace Contribution] AWS - IAM Identity Center (#28559) * Update Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py * Update AWSIAMIdentityCenter.pyl * Update pack_metadata.json * Update AWSIAMIdentityCenter_description.md * Update AWSIAMIdentityCenter.ymll * Delete generated API module * Removed unnecessary package --------- Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> * Update AWSIAMIdentityCenter.yml * Update README.md * Update README.md * Fixed Pack README --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

"pack contribution initial commit"

e7af513

content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jul 27, 2023

content-bot changed the base branch from master to contrib/xsoar-contrib_sepaprivate-contrib-AWS-IAMIdentityCenter July 27, 2023 10:49

content-bot assigned anas-yousef Jul 27, 2023

content-bot requested a review from anas-yousef July 27, 2023 10:49

anas-yousef added the pending-contributor The PR is pending the response of its creator label Aug 1, 2023

anas-yousef reviewed Aug 6, 2023

View reviewed changes

sepaprivate and others added 6 commits August 10, 2023 11:54

Update Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/…

d98dd67

…AWSIAMIdentityCenter.py Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

Delete integration-AWS_-_IAM_Identity_Center.yml

bc400e6

Update AWSIAMIdentityCenter.py

af61566

Fixing couple of issues

Update AWSIAMIdentityCenter.yml

377fafa

Update AWSIAMIdentityCenter.yml

cc8ea72

Update README.md

bfc5d3f

sepaprivate added 4 commits August 14, 2023 13:48

Update pack_metadata.json

623d822

Update AWSIAMIdentityCenter_description.md

cfcd652

Update AWSIAMIdentityCenter.yml

295e5c2

Update AWSIAMIdentityCenter.yml

a94b5e7

Delete generated API module

4085c7f

anas-yousef reviewed Aug 14, 2023

View reviewed changes

anas-yousef and others added 5 commits August 14, 2023 19:52

Removed unnecessary package

ee2502b

Added Api Module

1dbc328

Update AWSIAMIdentityCenter.py

00bdf9c

Remove commented functions

Update AWSIAMIdentityCenter.yml

856a0ad

Adding Required Descriptions to arguments

Merge branch 'contrib/xsoar-contrib_sepaprivate-contrib-AWS-IAMIdenti…

047fa0c

…tyCenter' into sepaprivate-contrib-AWS-IAMIdentityCenter

anas-yousef reviewed Aug 23, 2023

View reviewed changes

anas-yousef added the pending-demo Demo pending label Aug 23, 2023

anas-yousef reviewed Sep 13, 2023

View reviewed changes

sepaprivate added 5 commits September 13, 2023 15:51

Update AWSIAMIdentityCenter.py

ce66cc9

Fix issues

Update AWSIAMIdentityCenter.py

6bb673f

Modified couple of functions, and removed unnecessary function (Date) added the AmazonAPIModule as the import didn't work

Update AWSIAMIdentityCenter.py

f0624e8

Fix some formatting

Update AWSIAMIdentityCenter.yml

230a7e8

Add missing description fields

Update AWSIAMIdentityCenter.yml

b2f0ee2

Fixing missing fields and updating tag for boto3py3 docker image

sepaprivate added 2 commits September 17, 2023 11:31

Update AWSIAMIdentityCenter.py

edc3d44

Post Fixes

Update AWSIAMIdentityCenter.yml

b5a6bc4

Changes in Parameter Configurations

sepaprivate added 2 commits September 17, 2023 11:46

Merge branch 'contrib/xsoar-contrib_sepaprivate-contrib-AWS-IAMIdenti…

230ea93

…tyCenter' into sepaprivate-contrib-AWS-IAMIdentityCenter

Update AWSIAMIdentityCenter.yml

13f5c7c

Updating Docker image tag to latest version

anas-yousef reviewed Sep 18, 2023

View reviewed changes

sepaprivate added 2 commits September 18, 2023 12:41

Update AWSIAMIdentityCenter.py

61619a4

Remove generated code

Merge branch 'contrib/xsoar-contrib_sepaprivate-contrib-AWS-IAMIdenti…

0e22078

…tyCenter' into sepaprivate-contrib-AWS-IAMIdentityCenter

anas-yousef reviewed Sep 18, 2023

View reviewed changes

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py Outdated Show resolved Hide resolved

anas-yousef reviewed Sep 18, 2023

View reviewed changes

Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/AWSIAMIdentityCenter.py Outdated Show resolved Hide resolved

sepaprivate and others added 2 commits September 18, 2023 16:27

Update Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/…

5d3e10e

…AWSIAMIdentityCenter.py Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

Update Packs/AWS-IAMIdentityCenter/Integrations/AWSIAMIdentityCenter/…

aac101e

…AWSIAMIdentityCenter.py Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com>

anas-yousef added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Sep 19, 2023

anas-yousef approved these changes Sep 19, 2023

View reviewed changes

anas-yousef merged commit 285f34c into demisto:contrib/xsoar-contrib_sepaprivate-contrib-AWS-IAMIdentityCenter Sep 19, 2023
21 of 23 checks passed

content-bot mentioned this pull request Sep 19, 2023

[Marketplace Contribution] AWS - IAM Identity Center #29767

Merged

3 tasks

		from CommonServerPython import * # noqa: F401


		import botocore.exceptions

		elif command == 'aws-iam-identitycenter-get-group':
		get_user(args, client)

[Marketplace Contribution] AWS - IAM Identity Center #28559

[Marketplace Contribution] AWS - IAM Identity Center #28559

Conversation

xsoar-bot commented Jul 27, 2023

Status

Contributor

Description

Video Link

content-bot commented Jul 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anas-yousef commented Aug 6, 2023 • edited Loading

sepaprivate commented Aug 14, 2023

anas-yousef commented Aug 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anas-yousef left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anas-yousef left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sepaprivate commented Sep 13, 2023

sepaprivate commented Sep 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

content-bot commented Sep 19, 2023

anas-yousef commented Aug 6, 2023 •

edited

Loading

anas-yousef left a comment •

edited

Loading