Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pan os query logs time issue #28634

Merged
merged 15 commits into from Aug 17, 2023
Merged

Pan os query logs time issue #28634

merged 15 commits into from Aug 17, 2023

Conversation

gal-forer
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A fix to the date formatting query for the argument time-generated argument and adding date parser capabilities to the arguments and adding an argument to query by time after

Must have

  • Tests
  • Documentation

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.
Make sure to regenerate the readme inputs. Consider adding a natural language input example.

Packs/PAN-OS/ReleaseNotes/1_17_17.md Outdated Show resolved Hide resolved
Packs/PAN-OS/Integrations/Panorama/Panorama.yml Outdated Show resolved Hide resolved
Packs/PAN-OS/Integrations/Panorama/Panorama.yml Outdated Show resolved Hide resolved
Packs/PAN-OS/Integrations/Panorama/Panorama.yml Outdated Show resolved Hide resolved
gal-forer and others added 7 commits August 3, 2023 14:11
Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
# Conflicts:
#	Packs/PAN-OS/ReleaseNotes/1_17_17.md
#	Packs/PAN-OS/pack_metadata.json
# Conflicts:
#	Packs/PAN-OS/ReleaseNotes/2_1_2.md
@DeanArbel DeanArbel merged commit bf4ae62 into master Aug 17, 2023
10 of 14 checks passed
@DeanArbel DeanArbel deleted the pan-os-query-logs-time-issue branch August 17, 2023 11:22
TalNos pushed a commit that referenced this pull request Aug 20, 2023
* readme

* Added new after argument + enable date parser

* Added argument

* Added the time from arg to get logs after

* Release notes

* Release notes

* Fix unit test

* Apply suggestions from code review

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>

* update rn

* ignore mypy

* bump version

---------

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* readme

* Added new after argument + enable date parser

* Added argument

* Added the time from arg to get logs after

* Release notes

* Release notes

* Fix unit test

* Apply suggestions from code review

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>

* update rn

* ignore mypy

* bump version

---------

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* readme

* Added new after argument + enable date parser

* Added argument

* Added the time from arg to get logs after

* Release notes

* Release notes

* Fix unit test

* Apply suggestions from code review

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>

* update rn

* ignore mypy

* bump version

---------

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants