[MicrosoftManagementActivity] updated fetch start_time #28713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-management-activity-api
michal-dagan
changed the title
bziser
reviewed
Aug 3, 2023
| fetch_end_datetime = get_fetch_end_time_based_on_start_time(fetch_start_datetime) | ||
|
|
||
| # The API expects strings of format YYYY:DD:MMTHH:MM:SS | ||
| fetch_start_time_str = fetch_start_datetime.strftime(DATE_FORMAT) | ||
| fetch_end_time_str = fetch_end_datetime.strftime(DATE_FORMAT) | ||
| demisto.debug(f"get_fetch_start_and_end_time: {fetch_start_time_str=}, {fetch_end_time_str=}") |
There was a problem hiding this comment.
great that you added logging!
bziser
approved these changes
Aug 3, 2023
|
@bziser Doc review completed. Looks good. |
bziser
reviewed
Aug 3, 2023
Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md
Outdated
Show resolved
Hide resolved
…mentActivity/README.md Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
michal-dagan
commented
Aug 3, 2023
Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md
Outdated
Show resolved
Hide resolved
…mentActivity/README.md
ostolero
pushed a commit
that referenced
this pull request
Aug 8, 2023
* improved * improved * updated docker * added log * added docs * Update Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> * Update Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md --------- Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* improved * improved * updated docker * added log * added docs * Update Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> * Update Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md --------- Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* improved * improved * updated docker * added log * added docs * Update Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com> * Update Packs/MicrosoftManagementActivity/Integrations/MicrosoftManagementActivity/README.md --------- Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Fixed an issue where the start time for fetching incidents from the last retrieval was not parsed correctly.
From Microsoft docs: https://learn.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-reference#list-available-content:
Both must be specified (or both omitted) and they must be no more than 24 hours apart, with the start time no more than 7 days in the past. By default, if startTime and endTime are omitted, then the content available in the last 24 hours is returned.