Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CortexCoreIR] change the "email" argument of core-report-incorrect-wildfire #28859

Merged
merged 5 commits into from Aug 9, 2023

Conversation

bziser
Copy link
Contributor

@bziser bziser commented Aug 9, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Changed the email argument of the command core-report-incorrect-wildfire to be required as the command wouldn't return any results without it.

@bziser bziser marked this pull request as ready for review August 9, 2023 11:18
@bziser bziser requested a review from DeanArbel August 9, 2023 11:18
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a BC change notice (though it didn't work before)

@bziser
Copy link
Contributor Author

bziser commented Aug 9, 2023

Need to Force merge because of breaking backwards compatibility.
image

@DeanArbel DeanArbel merged commit d177197 into master Aug 9, 2023
12 of 16 checks passed
@DeanArbel DeanArbel deleted the XSUP-26537/core-report-incorrect-wildfire branch August 9, 2023 14:32
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
…ildfire (demisto#28859)

* changed the email to be required

* bc rn

* docker

* bc rn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants