Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panorama get address group command fix #28885

Merged
merged 13 commits into from Aug 13, 2023
Merged

Conversation

dansterenson
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Changed "show" to "get" in the API call params. When using "get" it gets the candidate config (before commit) instead of "show" param which gets only the active configuration (which is the configuration after the commit) :

@dansterenson dansterenson changed the title Panorama alert group fix Panorama get address group fix Aug 10, 2023
@dansterenson dansterenson changed the title Panorama get address group fix Panorama get address group command fix Aug 10, 2023
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
@dansterenson
Copy link
Contributor Author

Force merge needed:
Failed Tests: - PAN-OS - Add Anti-Spyware Security Profile To Rule - Test (Mock Disabled)

Fails on 6.8.0 machine, the test playbook fromversion is 6.9.0 and it seems like a bug in the build.

@DeanArbel DeanArbel merged commit 2c69dc0 into master Aug 13, 2023
10 of 11 checks passed
@DeanArbel DeanArbel deleted the panorama-alert-group-fix branch August 13, 2023 07:08
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* bug fix

* bug fix

* update docker

* Update Packs/PAN-OS/ReleaseNotes/2_1_1.md

Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>

---------

Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants