New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panorama get address group command fix #28885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansterenson
changed the title
Panorama get address group fix
Panorama get address group command fix
Aug 10, 2023
GuyAfik
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
GuyAfik
reviewed
Aug 10, 2023
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
… into panorama-alert-group-fix
… into panorama-alert-group-fix
Force merge needed: Fails on 6.8.0 machine, the test playbook fromversion is 6.9.0 and it seems like a bug in the build. |
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* bug fix * bug fix * update docker * Update Packs/PAN-OS/ReleaseNotes/2_1_1.md Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> --------- Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Changed "show" to "get" in the API call params. When using "get" it gets the candidate config (before commit) instead of "show" param which gets only the active configuration (which is the configuration after the commit) :