Netskope event collector rewrite #28941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core, DemistoRESTAPI, FiltersAndTransformers, Palo_Alto_Networks_WildFire, rasterize
…_update_core_packs_list
…_update_core_packs_list
…_update_core_packs_list
…sto/content into add_packs_to_update_core_packs_list
# Conflicts: # Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.yml
…nt_collector_rewrite
…ent_collector_rewrite # Conflicts: # Tests/Marketplace/core_packs_xpanse_list.json
# Conflicts: # Packs/Base/Scripts/CommonServerPython/CommonServerPython.py
…nt_collector_rewrite
…nt_collector_rewrite
…nt_collector_rewrite
…nt_collector_rewrite
Fixed UT
Shellyber
reviewed
Aug 21, 2023
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.yml
Show resolved
Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.yml
Outdated
Show resolved
Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector.py
Show resolved
Hide resolved
| | Trust any certificate (not secure) | | False | | ||
| | Use system proxy settings | | False | | ||
| | First fetch timestamp (<number> <time unit>, e.g., 12 hours, 7 days) | | False | | ||
| | Max events per fetch | The maximum amount of events to retrieve \(up to 30000 events\). | False | | ||
| | Max events per fetch | The maximum amount of events to retrieve per each event type. For more information about event types see the help section. | False | |
There was a problem hiding this comment.
Don't you want to add the limitations also to the readme?
Under the known limitation section?
There was a problem hiding this comment.
There was a problem hiding this comment.
My bad - Missed that.
Do we want to add also the API limitation regarding indexation?
There was a problem hiding this comment.
Waiting for the Netskope team investigation resolution on this
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector_test.py
Outdated
Show resolved
Hide resolved
- Added types to perform_data_export parameters - Removed unused code
Shellyber
approved these changes
Aug 24, 2023
|
Validation fails on removed parameters, this is by design as the first fetch is not relevant anymore |
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* Temporarily added the following packs to the update_core_packs_list: Core, DemistoRESTAPI, FiltersAndTransformers, Palo_Alto_Networks_WildFire, rasterize * Added all packs to update core list * Added al core packs to update_core_packs_list * Added new API endpoint * Added testing copies * changes from testing * changes from testing * changes from testing * Changed default first fecth * Added slipping for no wait time * First code change * Fixed description and log * UT fixes + mypy * UT fixes + mypy * Bumped Docker image and added rn * Formatting and typos * Fixed honor_rate_limit and added ut * Flake 8 fix * Added more UT * revert core list change * Enhanced docs * Small UT fixes * Removed is_command variable * Added docs Fixed UT * changes rn version * - Removed first_fetch param - Added types to perform_data_export parameters - Removed unused code * lint fixes * lint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Jira ticket
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-7622
Description
This is the mew implementation of Netskope event collector using the v2 dataexport