Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panorama add description field to commit command #28963

Merged
merged 4 commits into from Aug 16, 2023
Merged

Panorama add description field to commit command #28963

merged 4 commits into from Aug 16, 2023

Conversation

dansterenson
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

GuyAfik
GuyAfik approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a check for it in the existing unit-test that tests pan-os commit?

Packs/PAN-OS/ReleaseNotes/2_1_2.md Outdated Show resolved Hide resolved
@dansterenson
Copy link
Contributor Author

can you add a check for it in the existing unit-test that tests pan-os commit?

Fixed relevant UT

@dansterenson
Copy link
Contributor Author

Force merge needed: "PAN-OS - Add Anti-Spyware Security Profile To Rule - Test" Test playbook should not run on 6.8 machines, opened an issue: https://jira-hq.paloaltonetworks.local/browse/CIAC-7923

@DeanArbel DeanArbel merged commit c6d0605 into master Aug 16, 2023
17 of 18 checks passed
@DeanArbel DeanArbel deleted the pan-os-add-desc-to-commit branch August 16, 2023 13:47
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
@dansterenson @xsoar-bot
Panorama add description field to commit command (demisto#28963)
a350da7 
* Added desc

* update RN

* update RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyAfik GuyAfik GuyAfik approved these changes

Assignees
No one assigned
Labels
docs-approved ForceMerge
Projects
None yet
Milestone
No milestone
3 participants
@dansterenson @GuyAfik @DeanArbel