Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xsup 26357/fortisiem v2 fetch incidents without events #28974

Merged
merged 31 commits into from Aug 17, 2023

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented Aug 15, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-26357

Description

Fixed an issue in case of incidents without events. which would return code 400 with an error message and fails the command.

Must have

  • Tests
  • Documentation

@ShirleyDenkberg
Copy link
Contributor

@bziser Doc review completed.

@MosheEichler MosheEichler marked this pull request as ready for review August 15, 2023 09:19
@MosheEichler MosheEichler marked this pull request as draft August 15, 2023 11:15
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@MosheEichler MosheEichler marked this pull request as ready for review August 16, 2023 09:43
"""
Fetching events per incident.
Given:
- Incident ID wit/out events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Incident ID wit/out events.
- Incident ID without events.

@MosheEichler MosheEichler merged commit 2cd5f15 into master Aug 17, 2023
14 checks passed
@MosheEichler MosheEichler deleted the XSUP-26357/Fortisiem_v2_fetch_incidents branch August 17, 2023 17:58
TalNos pushed a commit that referenced this pull request Aug 20, 2023
* logs

* FortiSIEMV2 fixed the unpack error in formatting incidents

* RN

* docker

* docker RN

* logs

* conflicts

* revert changes

* RN fix

* remove logs

* docker

* RN

* pre-commit

* UT

* RN

* pre-commit fixes

* fix

* docs

* BC compatibility

* fixed UT

* CR fixes
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* logs

* FortiSIEMV2 fixed the unpack error in formatting incidents

* RN

* docker

* docker RN

* logs

* conflicts

* revert changes

* RN fix

* remove logs

* docker

* RN

* pre-commit

* UT

* RN

* pre-commit fixes

* fix

* docs

* BC compatibility

* fixed UT

* CR fixes
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* logs

* FortiSIEMV2 fixed the unpack error in formatting incidents

* RN

* docker

* docker RN

* logs

* conflicts

* revert changes

* RN fix

* remove logs

* docker

* RN

* pre-commit

* UT

* RN

* pre-commit fixes

* fix

* docs

* BC compatibility

* fixed UT

* CR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants