New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xsup 26357/fortisiem v2 fetch incidents without events #28974
Merged
MosheEichler
merged 31 commits into
master
from
XSUP-26357/Fortisiem_v2_fetch_incidents
Aug 17, 2023
Merged
Xsup 26357/fortisiem v2 fetch incidents without events #28974
MosheEichler
merged 31 commits into
master
from
XSUP-26357/Fortisiem_v2_fetch_incidents
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Packs/FortiSIEM/ReleaseNotes/2_0_16.md
# Conflicts: # Packs/FortiSIEM/Integrations/FortiSIEMV2/FortiSIEMV2_test.py
@bziser Doc review completed. |
bziser
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
bziser
reviewed
Aug 17, 2023
""" | ||
Fetching events per incident. | ||
Given: | ||
- Incident ID wit/out events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Incident ID wit/out events. | |
- Incident ID without events. |
bziser
approved these changes
Aug 17, 2023
TalNos
pushed a commit
that referenced
this pull request
Aug 20, 2023
* logs * FortiSIEMV2 fixed the unpack error in formatting incidents * RN * docker * docker RN * logs * conflicts * revert changes * RN fix * remove logs * docker * RN * pre-commit * UT * RN * pre-commit fixes * fix * docs * BC compatibility * fixed UT * CR fixes
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* logs * FortiSIEMV2 fixed the unpack error in formatting incidents * RN * docker * docker RN * logs * conflicts * revert changes * RN fix * remove logs * docker * RN * pre-commit * UT * RN * pre-commit fixes * fix * docs * BC compatibility * fixed UT * CR fixes
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* logs * FortiSIEMV2 fixed the unpack error in formatting incidents * RN * docker * docker RN * logs * conflicts * revert changes * RN fix * remove logs * docker * RN * pre-commit * UT * RN * pre-commit fixes * fix * docs * BC compatibility * fixed UT * CR fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-26357
Description
Fixed an issue in case of incidents without events. which would return code 400 with an error message and fails the command.
Must have