Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco SMA fixed spaces encoding in query params #29068

Merged
merged 8 commits into from Aug 29, 2023

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented Aug 20, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-26505

Related PRs

#29066

Description

Fixed an issue with spaces encoding in Cisco SMA query params.

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler marked this pull request as ready for review August 28, 2023 08:49
@bziser
Copy link
Contributor

bziser commented Aug 28, 2023

@MosheEichler
please take a look on the pre-commit, there is a need to update docker and run ruff on the code

@MosheEichler MosheEichler merged commit 4c44ca2 into master Aug 29, 2023
15 checks passed
@MosheEichler MosheEichler deleted the Cisco_SMA/Add-quote_params_via branch August 29, 2023 06:24
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* Added quote_params_via in message_search command

* RN

* params_parser

* pre-commit

* RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants