Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ciac 7986 #29137

Merged
merged 30 commits into from Sep 4, 2023
Merged

Ciac 7986 #29137

merged 30 commits into from Sep 4, 2023

Conversation

eyalpalo
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Added functionality to SetGridField automation to support context entries with nested dicts and lists.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.12.18.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

dantavori
dantavori approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see notes before merging

Packs/CommonScripts/.pack-ignore Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/SetGridField/README.md Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/SetGridField/README.md Outdated Show resolved Hide resolved
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.12.19.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.12.20.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@eyalpalo eyalpalo merged commit 890529e into master Sep 4, 2023
14 of 15 checks passed
@eyalpalo eyalpalo deleted the ciac_7986 branch September 4, 2023 10:16
amshamah419 pushed a commit that referenced this pull request Sep 4, 2023
@eyalpalo @dantavori @amshamah419
Ciac 7986 (#29137)
25cdc3e 
* added functionality and test

* rn

* lint fix

* Apply suggestions from code review

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* unit test fixes

* bug fix

* validations

* Bump pack from version CommonScripts to 1.12.18.

* pic

* readme

* CR fix

* Bump pack from version CommonScripts to 1.12.19.

* Bump pack from version CommonScripts to 1.12.20.

* changed datadir

* docker

* rn

* changed dataridr

* fix

* fix

* pre commit

* fixes

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
moishce pushed a commit that referenced this pull request Sep 14, 2023
@eyalpalo @dantavori @moishce
Ciac 7986 (#29137)
ece1c89 
* added functionality and test

* rn

* lint fix

* Apply suggestions from code review

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* unit test fixes

* bug fix

* validations

* Bump pack from version CommonScripts to 1.12.18.

* pic

* readme

* CR fix

* Bump pack from version CommonScripts to 1.12.19.

* Bump pack from version CommonScripts to 1.12.20.

* changed datadir

* docker

* rn

* changed dataridr

* fix

* fix

* pre commit

* fixes

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
@eyalpalo @dantavori @xsoar-bot
Ciac 7986 (demisto#29137)
4a2019f 
* added functionality and test

* rn

* lint fix

* Apply suggestions from code review

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* unit test fixes

* bug fix

* validations

* Bump pack from version CommonScripts to 1.12.18.

* pic

* readme

* CR fix

* Bump pack from version CommonScripts to 1.12.19.

* Bump pack from version CommonScripts to 1.12.20.

* changed datadir

* docker

* rn

* changed dataridr

* fix

* fix

* pre commit

* fixes

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
@eyalpalo @dantavori @moishce
Ciac 7986 (#29137)
b273a58 
* added functionality and test

* rn

* lint fix

* Apply suggestions from code review

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* unit test fixes

* bug fix

* validations

* Bump pack from version CommonScripts to 1.12.18.

* pic

* readme

* CR fix

* Bump pack from version CommonScripts to 1.12.19.

* Bump pack from version CommonScripts to 1.12.20.

* changed datadir

* docker

* rn

* changed dataridr

* fix

* fix

* pre commit

* fixes

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantavori dantavori dantavori approved these changes

@altmannyarden altmannyarden Awaiting requested review from altmannyarden altmannyarden is a code owner

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
3 participants
@eyalpalo @content-bot @dantavori