Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials part 15 #29171

Merged
merged 10 commits into from Aug 29, 2023
Merged

Align credentials part 15 #29171

merged 10 commits into from Aug 29, 2023

Conversation

jlevypaloalto
Copy link
Contributor

@jlevypaloalto jlevypaloalto commented Aug 23, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Align credentials and change secrets to type 4 for the following integrations:

  • Koodous
  • cisco-meraki

Must have

  • Tests
  • Documentation

@github-actions
Copy link

Your contributed DNSDB pack has been modified on files:

Packs/DNSDB/pack_metadata.json
Packs/DNSDB/Integrations/FarsightDNSDB/FarsightDNSDB.js
Packs/DNSDB/ReleaseNotes/2_1_19.md
Packs/DNSDB/Integrations/FarsightDNSDB/FarsightDNSDB.yml
Please review the changes here

@jlevypaloalto
Copy link
Contributor Author

This PR needs a force-merge as there are no unit-tests or test playbooks for Kooduos and we have no working instance of cisco-meraki.

@jlevypaloalto jlevypaloalto marked this pull request as ready for review August 28, 2023 11:22
@dantavori dantavori merged commit af84bbd into master Aug 29, 2023
18 of 21 checks passed
@dantavori dantavori deleted the jl-align-creds-15 branch August 29, 2023 07:42
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* FarsightDNSDB complete

* Koodous complete

* cisco-meraki complete

* Remove FarsightDNSDB

* refactor for Koodous

* remove cisco-meraki.js

* fix RN cisco-meraki

* Readme for Koodous

* Readme for Koodous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants