Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default argument values in Generate Password #29203

Merged
merged 4 commits into from Aug 25, 2023

Conversation

yaakovpraisler
Copy link
Contributor

@yaakovpraisler yaakovpraisler commented Aug 24, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue where no correct default values were given for max_* arguments.

Screenshot

Before and after the fix:
Screenshot 2023-08-24 at 15 36 34

Must have

  • Tests
  • Documentation

Packs/CommonScripts/ReleaseNotes/1_12_17.md Outdated Show resolved Hide resolved
@yaakovpraisler yaakovpraisler merged commit efe4711 into master Aug 25, 2023
18 checks passed
@yaakovpraisler yaakovpraisler deleted the fix-default-generate-password branch August 25, 2023 13:34
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* fix default argument values in generatePassword script

* release notes

* unit test

* CR and mypy fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants