Phishlabs fetch incidents bug #29206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalpalo
changed the title
dantavori
approved these changes
Sep 27, 2023
Packs/PhishLabs/Integrations/PhishLabsIOC_EIR/PhishLabsIOC_EIR.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
|
Need to be forced merged, fails because we dont have creds for this integration. @dantavori |
wolyslager
pushed a commit
to wolyslager/content
that referenced
this pull request
Sep 29, 2023
* added logs and last id duplication prevention * fix * revert * fix * bug_fix * improv * removed logs * rn * unit test * pre commit * Update Packs/PhishLabs/ReleaseNotes/1_1_16.md Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> * CR * ignore --------- Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
wolyslager
pushed a commit
to wolyslager/content
that referenced
this pull request
Oct 2, 2023
* added logs and last id duplication prevention * fix * revert * fix * bug_fix * improv * removed logs * rn * unit test * pre commit * Update Packs/PhishLabs/ReleaseNotes/1_1_16.md Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> * CR * ignore --------- Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* added logs and last id duplication prevention * fix * revert * fix * bug_fix * improv * removed logs * rn * unit test * pre commit * Update Packs/PhishLabs/ReleaseNotes/1_1_16.md Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> * CR * ignore --------- Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* added logs and last id duplication prevention * fix * revert * fix * bug_fix * improv * removed logs * rn * unit test * pre commit * Update Packs/PhishLabs/ReleaseNotes/1_1_16.md Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> * CR * ignore --------- Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
There was a bug with fetch as last run was not assigned with a value when no incidents were fetched.
Must have