Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jira] Added support for arguments jira-get-organizations #29217

Conversation

ennozdd
Copy link
Contributor

@ennozdd ennozdd commented Aug 25, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Aug 25, 2023
@content-bot content-bot changed the base branch from master to contrib/ennozdd_jira_organizations August 25, 2023 13:12
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MichaelYochpaz will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Aug 25, 2023
Copy link
Contributor

@MichaelYochpaz MichaelYochpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for the contribution :)
Looks good overall, just a few notes.

Packs/Jira/Integrations/JiraV2/JiraV2.py Outdated Show resolved Hide resolved
Packs/Jira/Integrations/JiraV2/JiraV2.py Outdated Show resolved Hide resolved
Packs/Jira/ReleaseNotes/3_0_11.md Outdated Show resolved Hide resolved
Packs/Jira/Integrations/JiraV2/JiraV2.yml Outdated Show resolved Hide resolved
Packs/Jira/Integrations/JiraV2/JiraV2.py Outdated Show resolved Hide resolved
@MichaelYochpaz MichaelYochpaz added the pending-contributor The PR is pending the response of its creator label Aug 27, 2023
ennozdd and others added 6 commits August 28, 2023 09:37
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
ennozdd and others added 9 commits August 31, 2023 09:28
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@MichaelYochpaz MichaelYochpaz added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. pending-contributor The PR is pending the response of its creator labels Aug 31, 2023
@MichaelYochpaz MichaelYochpaz added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Sep 3, 2023
@MichaelYochpaz MichaelYochpaz added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Sep 3, 2023
Copy link
Contributor

@MichaelYochpaz MichaelYochpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good job :)

@MichaelYochpaz MichaelYochpaz merged commit af37537 into demisto:contrib/ennozdd_jira_organizations Sep 4, 2023
23 of 25 checks passed
MichaelYochpaz added a commit that referenced this pull request Sep 4, 2023
* [Jira] Added support for arguments jira-get-organizations (#29217)

* master

* reverting crowdstrike.py

* get_organization modification

* added release notes

* bumped version

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* added more descriptive release note

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* comments

* mixed errors

* fixed issue

* code improvements

* improved the documentation

---------

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Minor fixes & improvements

* Pre-commit

* Add a message for empty results

* Improve readable output

---------

Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
amshamah419 pushed a commit that referenced this pull request Sep 4, 2023
* [Jira] Added support for arguments jira-get-organizations (#29217)

* master

* reverting crowdstrike.py

* get_organization modification

* added release notes

* bumped version

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* added more descriptive release note

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* comments

* mixed errors

* fixed issue

* code improvements

* improved the documentation

---------

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Minor fixes & improvements

* Pre-commit

* Add a message for empty results

* Improve readable output

---------

Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
moishce pushed a commit that referenced this pull request Sep 14, 2023
* [Jira] Added support for arguments jira-get-organizations (#29217)

* master

* reverting crowdstrike.py

* get_organization modification

* added release notes

* bumped version

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* added more descriptive release note

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* comments

* mixed errors

* fixed issue

* code improvements

* improved the documentation

---------

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Minor fixes & improvements

* Pre-commit

* Add a message for empty results

* Improve readable output

---------

Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
)

* [Jira] Added support for arguments jira-get-organizations (demisto#29217)

* master

* reverting crowdstrike.py

* get_organization modification

* added release notes

* bumped version

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* added more descriptive release note

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* comments

* mixed errors

* fixed issue

* code improvements

* improved the documentation

---------

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Minor fixes & improvements

* Pre-commit

* Add a message for empty results

* Improve readable output

---------

Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* [Jira] Added support for arguments jira-get-organizations (#29217)

* master

* reverting crowdstrike.py

* get_organization modification

* added release notes

* bumped version

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* Update Packs/Jira/Integrations/JiraV2/JiraV2.py

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>

* added more descriptive release note

* updated docker image

* Update Packs/Jira/Integrations/JiraV2/JiraV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/Jira/ReleaseNotes/3_0_12.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* comments

* mixed errors

* fixed issue

* code improvements

* improved the documentation

---------

Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Minor fixes & improvements

* Pre-commit

* Add a message for empty results

* Improve readable output

---------

Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
5 participants