New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jira] Added support for arguments jira-get-organizations #29217
[Jira] Added support for arguments jira-get-organizations #29217
Conversation
…_organizations
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MichaelYochpaz will know the proposed changes are ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for the contribution :)
Looks good overall, just a few notes.
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
… into jira_organizations
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
… into jira_organizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, good job :)
af37537
into
demisto:contrib/ennozdd_jira_organizations
* [Jira] Added support for arguments jira-get-organizations (#29217) * master * reverting crowdstrike.py * get_organization modification * added release notes * bumped version * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * added more descriptive release note * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comments * mixed errors * fixed issue * code improvements * improved the documentation --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Minor fixes & improvements * Pre-commit * Add a message for empty results * Improve readable output --------- Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
* [Jira] Added support for arguments jira-get-organizations (#29217) * master * reverting crowdstrike.py * get_organization modification * added release notes * bumped version * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * added more descriptive release note * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comments * mixed errors * fixed issue * code improvements * improved the documentation --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Minor fixes & improvements * Pre-commit * Add a message for empty results * Improve readable output --------- Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
* [Jira] Added support for arguments jira-get-organizations (#29217) * master * reverting crowdstrike.py * get_organization modification * added release notes * bumped version * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * added more descriptive release note * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comments * mixed errors * fixed issue * code improvements * improved the documentation --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Minor fixes & improvements * Pre-commit * Add a message for empty results * Improve readable output --------- Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
) * [Jira] Added support for arguments jira-get-organizations (demisto#29217) * master * reverting crowdstrike.py * get_organization modification * added release notes * bumped version * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * added more descriptive release note * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comments * mixed errors * fixed issue * code improvements * improved the documentation --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Minor fixes & improvements * Pre-commit * Add a message for empty results * Improve readable output --------- Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
* [Jira] Added support for arguments jira-get-organizations (#29217) * master * reverting crowdstrike.py * get_organization modification * added release notes * bumped version * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Update Packs/Jira/Integrations/JiraV2/JiraV2.py Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * added more descriptive release note * updated docker image * Update Packs/Jira/Integrations/JiraV2/JiraV2.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Jira/ReleaseNotes/3_0_12.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comments * mixed errors * fixed issue * code improvements * improved the documentation --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Minor fixes & improvements * Pre-commit * Add a message for empty results * Improve readable output --------- Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have