Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ewsv2 from argument fix #29297

Merged
merged 10 commits into from Aug 31, 2023
Merged

ewsv2 from argument fix #29297

merged 10 commits into from Aug 31, 2023

Conversation

JudahSchwartz
Copy link
Contributor

@JudahSchwartz JudahSchwartz commented Aug 29, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@JudahSchwartz JudahSchwartz changed the title different arg ewsv2 from argument fix Aug 30, 2023
@@ -2418,8 +2417,7 @@
error_message = ""

# Office365 regular maintenance case
if (isinstance(e, ErrorMailboxMoveInProgress | ErrorMailboxStoreUnavailable)) \
and 'outlook.office365.com' in EWS_SERVER:
if (isinstance(e, ErrorMailboxMoveInProgress | ErrorMailboxStoreUnavailable)) and 'outlook.office365.com' in EWS_SERVER:

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

The string
outlook.office365.com
may be at an arbitrary position in the sanitized URL.
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
@JudahSchwartz
Copy link
Contributor Author

there are 3 failing playbooks on ng
all of them failing before this pr.
1 of them I just opened a server bug for
the other 2 Moshe is continuing to investigate, there was an open bug on them before my py

@DeanArbel DeanArbel merged commit 706d79b into master Aug 31, 2023
14 of 18 checks passed
@DeanArbel DeanArbel deleted the fix_from_mail_ewsv2 branch August 31, 2023 13:03
moishce pushed a commit that referenced this pull request Sep 14, 2023
* different arg

* change from

* return from properly

* wrote test

* undo change

* update desc

* fix test

* fixed lint issues

* Update Packs/MicrosoftExchangeOnPremise/ReleaseNotes/2_0_7.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* different arg

* change from

* return from properly

* wrote test

* undo change

* update desc

* fix test

* fixed lint issues

* Update Packs/MicrosoftExchangeOnPremise/ReleaseNotes/2_0_7.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* different arg

* change from

* return from properly

* wrote test

* undo change

* update desc

* fix test

* fixed lint issues

* Update Packs/MicrosoftExchangeOnPremise/ReleaseNotes/2_0_7.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

---------

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants