-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace Contribution] Okta - Content Pack Update #29303
Merged
ostolero
merged 8 commits into
demisto:contrib/xsoar-contrib_parm-uh-lee-contrib-Okta
from
xsoar-contrib:parm-uh-lee-contrib-Okta
Sep 13, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
56e4db0
"contribution update to pack "Okta""
xsoar-bot ba325d9
minor fixes
ostolero 3a3f583
Merge branch 'contrib/xsoar-contrib_parm-uh-lee-contrib-Okta' into pa…
ostolero 57654d1
add outputs and readme
ostolero e9a7b0a
Merge branch 'contrib/xsoar-contrib_parm-uh-lee-contrib-Okta' into pa…
ostolero 46aedbb
add outputs description
ostolero 8edc4f8
update docker
ostolero 0806312
change outputs
ostolero File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,4 @@ | ||
Okta V2 | ||
- | ||
For information on getting your Okta API token, see the Okta documentation. | ||
https://developer.okta.com/docs/api/getting_started/getting_a_token | ||
|
||
|
||
--- | ||
[View Integration Documentation](https://xsoar.pan.dev/docs/reference/integrations/okta-v2) | ||
https://developer.okta.com/docs/api/getting_started/getting_a_token |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
|
||
#### Integrations | ||
|
||
##### Okta v2 | ||
|
||
- Added the okta-expire-password command which allows users to expire passwords for Okta users. | ||
- Updated the Docker image to: *demisto/python3:3.10.13.73190*. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this secnario we should first check we have a valid username, and then try to get the UserId. if we can't get a userId an eception is thrown form the get_user_id function. I changed the exception a bit accordingly. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ostolero,
I think you may have tagged the wrong individual, no worries :)
Regarding your proposed changes, this was definitely an oversight on my end and glad that you pointed it out. I agree that it would be better to handle the error and raise an exception before running the
get_user_id
method.Also, I went ahead and provided access to the MP4 file -- please view at your earliest convenience. Thanks!