Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xsup 27483/Report Object References #29327

Merged
merged 15 commits into from Sep 5, 2023

Conversation

AradCarmi
Copy link
Contributor

@AradCarmi AradCarmi commented Aug 30, 2023

Related Issues

fixes: link to the issue

Description

STIX report indicators pulled from the feed will now contain the Report Object References indicator field, which holds the IDs of related indicators.

@AradCarmi AradCarmi marked this pull request as ready for review August 31, 2023 08:07
@AradCarmi AradCarmi changed the title Xsup 27483/support relationships without Xsup 27483/Report Object References Aug 31, 2023
Copy link
Contributor

@Ni-Knight Ni-Knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do a small demo before merge? just us to make sure it works perfectly?

@AradCarmi
Copy link
Contributor Author

Can we do a small demo before merge? just us to make sure it works perfectly?

Yes I will schedule for the next week.

AradCarmi and others added 3 commits September 3, 2023 09:25
Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
…com:demisto/content into XSUP-27483/support_relationships_without_id
Copy link
Contributor

@sapirshuker sapirshuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job! please add unit-tests.

Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! see doc note

Packs/FeedDHS/ReleaseNotes/2_0_20.md Outdated Show resolved Hide resolved
@AradCarmi AradCarmi requested review from sapirshuker and removed request for sapirshuker September 5, 2023 07:15
@AradCarmi AradCarmi merged commit 5348068 into master Sep 5, 2023
19 of 20 checks passed
@AradCarmi AradCarmi deleted the XSUP-27483/support_relationships_without_id branch September 5, 2023 07:17
moishce pushed a commit that referenced this pull request Sep 14, 2023
* added support to report object grid

* updated release notes

* added new indicator field

* fixed ut

* Update Packs/FeedTAXII/ReleaseNotes/1_1_33.md

Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>

* fix the grid format

* fixed ut

* Update Packs/FeedDHS/ReleaseNotes/2_0_20.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* update rn

---------

Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* added support to report object grid

* updated release notes

* added new indicator field

* fixed ut

* Update Packs/FeedTAXII/ReleaseNotes/1_1_33.md

Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>

* fix the grid format

* fixed ut

* Update Packs/FeedDHS/ReleaseNotes/2_0_20.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* update rn

---------

Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* added support to report object grid

* updated release notes

* added new indicator field

* fixed ut

* Update Packs/FeedTAXII/ReleaseNotes/1_1_33.md

Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>

* fix the grid format

* fixed ut

* Update Packs/FeedDHS/ReleaseNotes/2_0_20.md

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* update rn

---------

Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants