Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - EXPANDR-5879 #29528

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5879

Description

Simple bug fix

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Sep 6, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_ASM-EXPANDR-5879 September 6, 2023 21:15
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MichaelYochpaz will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@johnnywilkes johnnywilkes marked this pull request as draft September 6, 2023 21:28
@johnnywilkes
Copy link
Contributor Author

@capanw / @BigEasyJ , please review

@johnnywilkes johnnywilkes marked this pull request as ready for review September 6, 2023 22:00
@johnnywilkes
Copy link
Contributor Author

@melamedbn / @MichaelYochpaz , this has been approved from Xpanse, please merge when possible

@MichaelYochpaz MichaelYochpaz added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Sep 7, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6259598

Copy link
Contributor

@MichaelYochpaz MichaelYochpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@MichaelYochpaz MichaelYochpaz merged commit 9a52b0a into demisto:contrib/PaloAltoNetworks_ASM-EXPANDR-5879 Sep 7, 2023
48 of 49 checks passed
@content-bot content-bot mentioned this pull request Sep 7, 2023
5 tasks
MichaelYochpaz added a commit that referenced this pull request Sep 10, 2023
* update play

* RN

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
moishce pushed a commit that referenced this pull request Sep 14, 2023
* update play

* RN

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
@johnnywilkes johnnywilkes deleted the ASM-EXPANDR-5879 branch September 25, 2023 18:11
wolyslager pushed a commit to wolyslager/content that referenced this pull request Oct 2, 2023
* update play

* RN

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* update play

* RN

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* update play

* RN

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
5 participants