Devo bug fix v1.2.8 #29714

tejashree-metron · 2023-09-18T12:54:17Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: Unsupported formats for from (and to) parameters:

Description

Fixed the issue to support natural language (e.g., 2 day, 3 week), Unix timestamps, Python datetime objects, and string datetimes formats for from_time and to_time parameters.
Added the unit tests for formats of time.
Updated the Docker image to: demisto/devo:1.0.0.75198.

NOTE : As customer is waiting for this changes, please merge it on priority.

Must have

Tests
Documentation

…ll formats of from time input.

…nt fix.

Modified the get_time_range function and updated the test cases for a…

Small fix in to_to parameter to accept python datetime object.

content-bot · 2023-09-18T12:56:33Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @RosenbergYehuda will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

…v1.2.8

RosenbergYehuda

Hello @tejashree-metron,

You did a great job on this contribution! I added some minor comments - please take a look and let me know if you have any questions. Once you've addressed those, we can move forward with scheduling a demo to see it in action.

Thank you for your work on this. I appreciate you making this contribution to improve our content. Please let me know if you need anything else from me at this stage!

Regards,
Yehuda

Packs/Devo/ReleaseNotes/1_2_8.md

Packs/Devo/Integrations/Devo_v2/Devo_v2.py

…v1.2.8

…to DevoBugFix-v1.2.8

tejashree-metron · 2023-09-21T12:06:33Z

@RosenbergYehuda Can you please take a look at few checks(Review Release Notes / release_notes_review (pull_request) and ci/circleci: Run Validations) which are failing.

RosenbergYehuda · 2023-09-21T21:51:00Z

Hello @tejashree-metron,
I want to mention that due to the holiday season in Israel, our team will be out of the office until next Tuesday the 26th. I see you have already addressed my comments, and I will review again when I'm back.

Thank you again for your contribution. I look forward to getting it merged upon my return from the holiday break. Enjoy your weekend!

kapil-metron · 2023-09-27T07:37:56Z

Hi @RosenbergYehuda , can you please check why a check is still failing for this PR. Thanks in advanced.

…v1.2.8

…to DevoBugFix-v1.2.8

RosenbergYehuda

Hello @tejashree-metron,

Apologies for the delay, and thank you for your patience. I am approving this PR.

Regarding the errors in the build, you can ignore those - I will handle that in an internal PR.

I see the CLA was not filled out. This may be because someone else merged into this PR, so please go ahead and complete it.

Lastly, I would like to understand the bug fix better - could you please send a short video showing:

The version before your fix, demonstrating the bug
This fixed version, showing how the bug is now resolved
This will help me verify that the issue is fully addressed. Please let me know if you have any other questions!

RosenbergYehuda · 2023-09-28T22:10:04Z

Hello @tejashree-metron ,
I wanted to let you know that I will be on vacation next week due to the holidays here in Israel. I will return to work on October 8th.

Please accept my apologies for any delays this may cause.
Looking forward to catching up when I'm back in the office.

Regards,Yehuda

RosenbergYehuda · 2023-09-29T06:28:52Z

My mistake, I typed January instead of October, I am on vacation until the 8th of October.

tejashree-metron · 2023-09-29T07:04:20Z

Hi @RosenbergYehuda ,
The demo video is ready, can you please let me know how I can share the video with you. Also about the CLA, where do we have to sign it and share, can you please guide on this.Thanks

RosenbergYehuda · 2023-09-29T08:31:01Z

You can attach the video here as a comment, or share it via Google Drive with me at yrosenberg@paloaltonetworks.com.

Regarding the CLA, it's strange I don't see it on this PR, but this is the link to submit it: https://cla-assistant.io/demisto/content?pullRequest=29714

Please fill it out and see if the "license/cla" GitHub check turns green. If not, that likely means someone else contributed to this PR without filling out the form - it looks like that may be kapil-metron (https://github.com/kapil-metron).

Let me know if you have any trouble getting the CLA submitted. We need to have it from all contributors before we can merge.

RosenbergYehuda · 2023-09-29T10:08:26Z

Great Demo @tejashree-metron!!
Did all contributors fill out the CLA?

RosenbergYehuda · 2023-09-29T10:23:39Z

One more thing - there are merge conflicts with master that I don't have permissions to fix.

The conflicts are because our bot updated the Docker image and the latest version is now 1_2_8.

Could you please update the release notes version to the next one, and remove the line updating the docker image?

Also don't forget to update the metadata file with the new version.

This should resolve the conflicts so we can get your contribution merged. Let me know if you need any help with the version bump or resolving the merge conflicts.

…v1.2.8

tejashree-metron · 2023-09-29T14:36:44Z

Hi @RosenbergYehuda , I have resolved the conflicts , can you please merge it.

* Devo bug fix v1.2.8 (#29714) * Modified the get_time_range function and updated the test cases for all formats of from time input. * Updated the docker image and created the release notes and a small lint fix. * Supported Python datetime object format * Modified the test case for python datetime object. * Small fix in to_to parameter to accept python datetime object. * Updated the docker image. * Updated the release notes. * Updated the docker image. * Updated the docker image tag. * Updated the release notes. --------- Co-authored-by: Kapil Bisen <kapil@metronlabs.com> Co-authored-by: manas-metron <108781525+manas-metron@users.noreply.github.com> Co-authored-by: Sahil Kakad <108385016+sahil-metron@users.noreply.github.com> Co-authored-by: kapil-metron <58544320+kapil-metron@users.noreply.github.com> * RN --------- Co-authored-by: tejashree-metron <121784786+tejashree-metron@users.noreply.github.com> Co-authored-by: Kapil Bisen <kapil@metronlabs.com> Co-authored-by: manas-metron <108781525+manas-metron@users.noreply.github.com> Co-authored-by: Sahil Kakad <108385016+sahil-metron@users.noreply.github.com> Co-authored-by: kapil-metron <58544320+kapil-metron@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>

* Devo bug fix v1.2.8 (demisto#29714) * Modified the get_time_range function and updated the test cases for all formats of from time input. * Updated the docker image and created the release notes and a small lint fix. * Supported Python datetime object format * Modified the test case for python datetime object. * Small fix in to_to parameter to accept python datetime object. * Updated the docker image. * Updated the release notes. * Updated the docker image. * Updated the docker image tag. * Updated the release notes. --------- Co-authored-by: Kapil Bisen <kapil@metronlabs.com> Co-authored-by: manas-metron <108781525+manas-metron@users.noreply.github.com> Co-authored-by: Sahil Kakad <108385016+sahil-metron@users.noreply.github.com> Co-authored-by: kapil-metron <58544320+kapil-metron@users.noreply.github.com> * RN --------- Co-authored-by: tejashree-metron <121784786+tejashree-metron@users.noreply.github.com> Co-authored-by: Kapil Bisen <kapil@metronlabs.com> Co-authored-by: manas-metron <108781525+manas-metron@users.noreply.github.com> Co-authored-by: Sahil Kakad <108385016+sahil-metron@users.noreply.github.com> Co-authored-by: kapil-metron <58544320+kapil-metron@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>

* Devo bug fix v1.2.8 (#29714) * Modified the get_time_range function and updated the test cases for all formats of from time input. * Updated the docker image and created the release notes and a small lint fix. * Supported Python datetime object format * Modified the test case for python datetime object. * Small fix in to_to parameter to accept python datetime object. * Updated the docker image. * Updated the release notes. * Updated the docker image. * Updated the docker image tag. * Updated the release notes. --------- Co-authored-by: Kapil Bisen <kapil@metronlabs.com> Co-authored-by: manas-metron <108781525+manas-metron@users.noreply.github.com> Co-authored-by: Sahil Kakad <108385016+sahil-metron@users.noreply.github.com> Co-authored-by: kapil-metron <58544320+kapil-metron@users.noreply.github.com> * RN --------- Co-authored-by: tejashree-metron <121784786+tejashree-metron@users.noreply.github.com> Co-authored-by: Kapil Bisen <kapil@metronlabs.com> Co-authored-by: manas-metron <108781525+manas-metron@users.noreply.github.com> Co-authored-by: Sahil Kakad <108385016+sahil-metron@users.noreply.github.com> Co-authored-by: kapil-metron <58544320+kapil-metron@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>

tejashree-metron and others added 8 commits September 14, 2023 19:09

Modified the get_time_range function and updated the test cases for a…

9c099ed

…ll formats of from time input.

Updated the docker image and created the release notes and a small li…

ecbbd5c

…nt fix.

Supported Python datetime object format

6ae2a59

Modified the test case for python datetime object.

f2beba4

Merge pull request #617 from metron-labs/Devo-update

34a5a90

Modified the get_time_range function and updated the test cases for a…

Small fix in to_to parameter to accept python datetime object.

c22c878

Merge pull request #618 from metron-labs/Devo-update

297b141

Small fix in to_to parameter to accept python datetime object.

Merge branch 'demisto:master' into DevoBugFix-v1.2.8

49a0334

content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Sep 18, 2023

content-bot changed the base branch from master to contrib/metron-labs_DevoBugFix-v1.2.8 September 18, 2023 12:56

content-bot assigned RosenbergYehuda Sep 18, 2023

content-bot requested a review from RosenbergYehuda September 18, 2023 12:56

content-bot assigned edik24 Sep 18, 2023

content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Sep 18, 2023

tejashree-metron and others added 5 commits September 18, 2023 18:27

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

33bebd5

…v1.2.8

Updated the docker image.

aa0669c

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

3d5391b

…v1.2.8

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

8482cb2

…v1.2.8

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

e5e2ea6

…v1.2.8

RosenbergYehuda reviewed Sep 20, 2023

View reviewed changes

Packs/Devo/ReleaseNotes/1_2_8.md Outdated Show resolved Hide resolved

Packs/Devo/Integrations/Devo_v2/Devo_v2.py Show resolved Hide resolved

RosenbergYehuda added the pending-contributor The PR is pending the response of its creator label Sep 20, 2023

tejashree-metron and others added 4 commits September 21, 2023 10:04

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

c40bf64

…v1.2.8

Updated the release notes.

a682d47

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

26ca81b

…v1.2.8

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

83fa1ba

…v1.2.8

manas-metron and others added 3 commits September 21, 2023 16:47

Merge branch 'demisto:master' into DevoBugFix-v1.2.8

ca276e6

Updated the docker image.

d3dbefa

Merge branch 'DevoBugFix-v1.2.8' of github.com:metron-labs/content in…

5dc00a2

…to DevoBugFix-v1.2.8

tejashree-metron and others added 4 commits September 27, 2023 13:58

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

b48debb

…v1.2.8

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

396d705

…v1.2.8

Updated the docker image tag.

46da637

Merge branch 'DevoBugFix-v1.2.8' of github.com:metron-labs/content in…

96f513f

…to DevoBugFix-v1.2.8

RosenbergYehuda self-requested a review September 27, 2023 15:31

RosenbergYehuda approved these changes Sep 27, 2023

View reviewed changes

RosenbergYehuda added docs-approved post-demo labels Sep 29, 2023

tejashree-metron and others added 2 commits September 29, 2023 16:19

Updated the release notes.

4450f34

Merge branch 'contrib/metron-labs_DevoBugFix-v1.2.8' into DevoBugFix-…

ebf86da

…v1.2.8

RosenbergYehuda merged commit 18df65c into demisto:contrib/metron-labs_DevoBugFix-v1.2.8 Oct 1, 2023
19 of 20 checks passed

content-bot mentioned this pull request Oct 1, 2023

Devo bug fix v1.2.8 #29962

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Devo bug fix v1.2.8 #29714

Devo bug fix v1.2.8 #29714

tejashree-metron commented Sep 18, 2023 •

edited

Loading

content-bot commented Sep 18, 2023

RosenbergYehuda left a comment

tejashree-metron commented Sep 21, 2023

RosenbergYehuda commented Sep 21, 2023

kapil-metron commented Sep 27, 2023

RosenbergYehuda left a comment

RosenbergYehuda commented Sep 28, 2023 •

edited

Loading

RosenbergYehuda commented Sep 29, 2023

tejashree-metron commented Sep 29, 2023

RosenbergYehuda commented Sep 29, 2023

RosenbergYehuda commented Sep 29, 2023

RosenbergYehuda commented Sep 29, 2023

tejashree-metron commented Sep 29, 2023

Devo bug fix v1.2.8 #29714

Devo bug fix v1.2.8 #29714

Conversation

tejashree-metron commented Sep 18, 2023 • edited Loading

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

content-bot commented Sep 18, 2023

RosenbergYehuda left a comment

Choose a reason for hiding this comment

tejashree-metron commented Sep 21, 2023

RosenbergYehuda commented Sep 21, 2023

kapil-metron commented Sep 27, 2023

RosenbergYehuda left a comment

Choose a reason for hiding this comment

RosenbergYehuda commented Sep 28, 2023 • edited Loading

RosenbergYehuda commented Sep 29, 2023

tejashree-metron commented Sep 29, 2023

RosenbergYehuda commented Sep 29, 2023

RosenbergYehuda commented Sep 29, 2023

RosenbergYehuda commented Sep 29, 2023

tejashree-metron commented Sep 29, 2023

tejashree-metron commented Sep 18, 2023 •

edited

Loading

RosenbergYehuda commented Sep 28, 2023 •

edited

Loading