Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft graph applications enhancement #29750

Merged
merged 45 commits into from Oct 1, 2023

Conversation

rshunim
Copy link
Contributor

@rshunim rshunim commented Sep 19, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-7802

Description

For the current cloud use case effort, adding the following missing API calls

Must have

  • Tests
  • Documentation

@rshunim rshunim self-assigned this Sep 19, 2023
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

rshunim and others added 9 commits September 26, 2023 11:52
…plications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
…plications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
…ancement' into Microsoft_Graph_Applications_Enhancement
@rshunim rshunim merged commit d2a94be into master Oct 1, 2023
18 checks passed
@rshunim rshunim deleted the Microsoft_Graph_Applications_Enhancement branch October 1, 2023 05:41
wolyslager pushed a commit to wolyslager/content that referenced this pull request Oct 2, 2023
* remove_service_principals_command was edited and a UT was added for it.
get_service_principal_command was implemented and a UT was added for it.

* update command with UT

* password add and remove with UTs

* autopep8

* change application to service principal

* add new command

* remove dev from yml

* CR fixes

* pre commit

* README.md

* improve implementation

* add two UTs

* fix pre commit

* fix pre commit

* add UT

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.yml

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* CR's fixes

* mypy error

* fixture

* fix description

* fix description

* CR's fixes

* command examples were added

* Demo's fixes

* docker image

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* remove_service_principals_command was edited and a UT was added for it.
get_service_principal_command was implemented and a UT was added for it.

* update command with UT

* password add and remove with UTs

* autopep8

* change application to service principal

* add new command

* remove dev from yml

* CR fixes

* pre commit

* README.md

* improve implementation

* add two UTs

* fix pre commit

* fix pre commit

* add UT

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.yml

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* CR's fixes

* mypy error

* fixture

* fix description

* fix description

* CR's fixes

* command examples were added

* Demo's fixes

* docker image

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* remove_service_principals_command was edited and a UT was added for it.
get_service_principal_command was implemented and a UT was added for it.

* update command with UT

* password add and remove with UTs

* autopep8

* change application to service principal

* add new command

* remove dev from yml

* CR fixes

* pre commit

* README.md

* improve implementation

* add two UTs

* fix pre commit

* fix pre commit

* add UT

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.yml

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* Update Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/MicrosoftGraphApplications.py

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

* CR's fixes

* mypy error

* fixture

* fix description

* fix description

* CR's fixes

* command examples were added

* Demo's fixes

* docker image

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants