Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft atp list no category #29755

Merged
merged 30 commits into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c53acd0
Added category support
Sep 19, 2023
bb80572
saave rn
Sep 19, 2023
23e60f2
validations + pre-commit fixes
Sep 19, 2023
bfd6bcd
Update Packs/MicrosoftDefenderAdvancedThreatProtection/ReleaseNotes/1…
daryakoval Sep 19, 2023
e90c076
fix test playbook
Sep 19, 2023
48a2840
Merge branch 'master' into microsoft-atp-list-no-category
daryakoval Sep 19, 2023
6143dc1
Merge branch 'master' into microsoft-atp-list-no-category
daryakoval Sep 19, 2023
089f6c3
fix test playbook
Sep 20, 2023
e659cad
Merge branch 'master' into microsoft-atp-list-no-category
Sep 20, 2023
7451c4a
new docker
Sep 20, 2023
aa0d7bb
fix test playbook
Sep 20, 2023
a0db908
Merge branch 'master' into microsoft-atp-list-no-category
Sep 20, 2023
fa832e0
Merge branch 'master' into microsoft-atp-list-no-category
Sep 20, 2023
e42164a
Merge branch 'master' into microsoft-atp-list-no-category
RosenbergYehuda Sep 20, 2023
c4945cc
Merge branch 'master' into microsoft-atp-list-no-category
daryakoval Sep 21, 2023
b9de797
trying without docker change
Sep 21, 2023
3bb689a
Merge branch 'master' into microsoft-atp-list-no-category
Sep 21, 2023
4054e11
docker update
Sep 21, 2023
5d42194
Merge branch 'master' into microsoft-atp-list-no-category
Sep 21, 2023
49344b6
Merge branch 'master' into microsoft-atp-list-no-category
Sep 21, 2023
112d7c1
save rn
Sep 21, 2023
ad7092a
Update Packs/Active_Directory_Query/ReleaseNotes/1_6_24.md
daryakoval Sep 25, 2023
4395012
Merge branch 'master' into microsoft-atp-list-no-category
daryakoval Sep 25, 2023
fbe5d83
update docker
Sep 26, 2023
8440f6e
Merge branch 'master' into microsoft-atp-list-no-category
Sep 26, 2023
5f20306
Merge branch 'master' into microsoft-atp-list-no-category
daryakoval Sep 26, 2023
160b0af
Merge branch 'master' into microsoft-atp-list-no-category
daryakoval Sep 26, 2023
714877a
Merge branch 'master' into microsoft-atp-list-no-category
daryakoval Sep 26, 2023
4684863
fix test playbook
Sep 26, 2023
9e27f0a
Merge branch 'master' into microsoft-atp-list-no-category
Sep 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions Packs/Active_Directory_Query/ReleaseNotes/1_6_24.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Active Directory Query v2

- Fixed an issue where the *category* argument of the ***microsoft-atp-list-alerts*** command did not work properly.
2 changes: 1 addition & 1 deletion Packs/Active_Directory_Query/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Active Directory Query",
"description": "Active Directory Query integration enables you to access and manage Active Directory objects (users, contacts, and computers).",
"support": "xsoar",
"currentVersion": "1.6.23",
"currentVersion": "1.6.24",
"author": "Cortex XSOAR",
"url": "",
"email": "",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2589,11 +2589,13 @@ def list_alerts_command(client: MsClient, args: dict):
'ThreatFamilyName', 'MachineID']
severity = args.get('severity')
status = args.get('status')
category = args.get('category')
limit = arg_to_number(args.get('limit', 50))
creation_time = arg_to_datetime(args.get('creation_time'), required=False)
fields_to_filter_by = {
'severity': severity,
'status': status
'status': status,
'category': category,
}
filter_req = reformat_filter(fields_to_filter_by)
alerts_response = client.list_alerts(filter_req, limit, creation_time=creation_time, evidence=True)
Expand Down Expand Up @@ -3668,7 +3670,7 @@ def _get_incidents_query_params(client, fetch_evidence, last_fetch_time):
sources = argToList(client.alert_detectionsource_to_fetch)
source_filter_list = [f"detectionSource+eq+'{DETECTION_SOURCE_TO_API_VALUE[source]}'" for source in sources]
if len(source_filter_list) > 1:
source_filter_list = list(map(lambda x: f"({x})", source_filter_list))
source_filter_list = [f"({x})" for x in source_filter_list]
filter_query = filter_query + " and (" + " or ".join(source_filter_list) + ")"
if client.alert_status_to_fetch:
statuses = argToList(client.alert_status_to_fetch)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5525,7 +5525,7 @@ script:
execution: false
name: microsoft-atp-auth-reset
arguments: []
dockerimage: demisto/crypto:1.0.0.74660
dockerimage: demisto/crypto:1.0.0.74979
isfetch: true
runonce: false
script: '-'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Microsoft Defender for Endpoint
- Updated the Docker image to: *demisto/crypto:1.0.0.74979*.
- Fixed an issue where the *category* argument of the ***microsoft-atp-list-alerts*** command did not work properly.