Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dra-cvss-color-fix #29757

Merged
merged 10 commits into from Sep 20, 2023
Merged

Dra-cvss-color-fix #29757

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b38d7c4
Fixed a small issue when indicator had no custom fields
Ni-Knight Sep 19, 2023
550bbea
RN
Ni-Knight Sep 19, 2023
26d7dbd
docker bump
Ni-Knight Sep 19, 2023
b8ad405
RN
Ni-Knight Sep 19, 2023
884e394
Update CVECVSSColor.py
Ni-Knight Sep 19, 2023
5eb90fd
Merge branch 'master' into dra-cvss-color-fix
Ni-Knight Sep 19, 2023
2e4777c
Merge branch 'master' into dra-cvss-color-fix
Ni-Knight Sep 20, 2023
c96ed3c
Merge branch 'master' into dra-cvss-color-fix
Ni-Knight Sep 20, 2023
e35e290
docker bump
Ni-Knight Sep 20, 2023
a37f2c4
RN
Ni-Knight Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions Packs/CommonScripts/ReleaseNotes/1_12_24.md
View file
Open in desktop
@@ -0,0 +1,7 @@

#### Scripts

##### cvss_color
- Updated the Docker image to: *demisto/python3:3.10.13.73190*.

- Fixed an issue where the script failed if the indicator had no custom fields.
4 changes: 2 additions & 2 deletions Packs/CommonScripts/Scripts/CVECVSSColor/CVECVSSColor.py
View file
Open in desktop
Expand Up @@ -42,8 +42,8 @@ def get_color(cvss: int | float) -> str:


def main():
indicator = demisto.callingContext.get('args', '').get('indicator', '')
cvss = indicator.get('CustomFields', '').get('cvssscore', '')
indicator = demisto.callingContext.get('args', {}).get('indicator', {})
cvss = indicator.get('CustomFields', {}).get('cvssscore', '')
theme = demisto.callingContext.get('context', 'light').get('User', 'light').get('theme', 'light')
cvss = 0 if not cvss else float(cvss)

Expand Down
2 changes: 1 addition & 1 deletion Packs/CommonScripts/Scripts/CVECVSSColor/CVECVSSColor.yml
View file
Open in desktop
@@ -1,4 +1,4 @@
commonfields:

Check failure on line 1 in Packs/CommonScripts/Scripts/CVECVSSColor/CVECVSSColor.yml

View workflow job for this annotation

GitHub Actions / pre-commit

Validation Error DO106 

The docker image tag is not the latest numeric tag, please update it.
The docker image tag in the yml file is: 3.10.13.73190
The latest docker image tag in docker hub is: 3.10.13.74666

You can check for the most updated version of demisto/python3 here: https://hub.docker.com/r/demisto/python3/tags 
To update the docker image run:
demisto-sdk format -ud -i Packs/CommonScripts/Scripts/CVECVSSColor/CVECVSSColor.yml
id: cvss_color
version: -1
name: cvss_color
Expand All @@ -11,7 +11,7 @@
scripttarget: 0
subtype: python3
runonce: false
dockerimage: demisto/python3:3.10.12.63474
dockerimage: demisto/python3:3.10.13.73190
runas: DBotWeakRole
fromversion: 6.5.0
tests:
Expand Down
2 changes: 1 addition & 1 deletion Packs/CommonScripts/pack_metadata.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"name": "Common Scripts",
"description": "Frequently used scripts pack.",
"support": "xsoar",
"currentVersion": "1.12.23",
"currentVersion": "1.12.24",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down