Graph single mail html 2 #29902
Merged
Graph single mail html 2 #29902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rebased GraphSingleMail-HTML * Minor changes pre PR * Release note update post validation * Fixing linter issues * return the "demisto.info" line * removing the "demisto.info" line --------- Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>
content-bot
added
Contribution
Packs/MicrosoftGraphMail/Integrations/MicrosoftGraphListener/MicrosoftGraphListener.yml
Outdated
Show resolved
Hide resolved
Packs/MicrosoftGraphMail/Integrations/MicrosoftGraphListener/MicrosoftGraphListener.yml
Outdated
Show resolved
Hide resolved
Packs/MicrosoftGraphMail/Integrations/MicrosoftGraphListener/README.md
Outdated
Show resolved
Hide resolved
|
@michal-dagan @RosenbergYehuda Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
RotemAmit
approved these changes
Oct 4, 2023
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* Graph single mail html 2 (demisto#29839) * Rebased GraphSingleMail-HTML * Minor changes pre PR * Release note update post validation * Fixing linter issues * return the "demisto.info" line * removing the "demisto.info" line --------- Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com> * Apply suggestions from Shirley Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * format * pre commit * unit test fix * flake 8 * updated the release notes * update the docker image --------- Co-authored-by: Anonymoo53 <93589159+Anonymoo53@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com> Co-authored-by: Yehuda Rosenberg <90599084+RosenbergYehuda@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Graph single mail html 2 (#29839) * Rebased GraphSingleMail-HTML * Minor changes pre PR * Release note update post validation * Fixing linter issues * return the "demisto.info" line * removing the "demisto.info" line --------- Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com> * Apply suggestions from Shirley Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * format * pre commit * unit test fix * flake 8 * updated the release notes * update the docker image --------- Co-authored-by: Anonymoo53 <93589159+Anonymoo53@users.noreply.github.com> Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com> Co-authored-by: Yehuda Rosenberg <90599084+RosenbergYehuda@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@Anonymoo53
Status
Related Issues
fixes: link to the issue
Description
This update clones functionality from the GraphMail integration for retrieving the HTML bodies of email into the Listener integration. The listener integration does not pull the HTML bodies of email and is hardcoded to only pull text based representations of emails. This change does not completely align the two integrations and there are still significant differences between them.
The changes are:
GraphMail fetch code has been moved to a separate module.
The previous GraphListener fetch code has been removed. Integration now relies on the Graph mail fetch from the new module, with minor changes.
There is now a checkbox in the Graph Listener configuration that allows HTML email bodies to be retrieved as HTML rather than plain text.
Must have
As discussed @RosenbergYehuda, for legibility and easier merging, this is a rebased version of PR #29454