Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP - Expandr-6261 #29951

Merged
merged 10 commits into from Oct 5, 2023
Merged

GCP - Expandr-6261 #29951

merged 10 commits into from Oct 5, 2023

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6261

Description

Updated the to naming standard of the firewall rules to be in the format remediation-<block|allow>-<vpc name>-port-<port nubmer>-<tcp|udp>, where the VPC name is truncated to 30 characters to meet the overall 63 character limit for firewall rule names. This ensures that unique firewall names are made in each VPC that a firewall rule could be created.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Sep 28, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_GCP-EXPANDR-6261 September 28, 2023 20:25
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , if you can please review

@ShirleyDenkberg ShirleyDenkberg self-assigned this Oct 1, 2023
@ShirleyDenkberg
Copy link
Contributor

@melamedbn @sapirshuker Doc review completed.

@sapirshuker
Copy link
Contributor

Hi @johnnywilkes,
Thank you for your contribution.
Your PR review will be slightly delayed technical problems, I apologize in advance.
I'm available for any of your questions here or on slack.
Thanks again.

@melamedbn
Copy link
Contributor

Hi @johnnywilkes,
Everything looks great. Can you please do a short demo (recording) of the playbook execution?

Thanks,
Ben

@sapirshuker sapirshuker added the pending-demo Demo pending label Oct 4, 2023
@johnnywilkes
Copy link
Contributor Author

@melamedbn , i sent you a link from gdrive. Also, here is the Xpanse documentation I referenced in the video: https://docs-cortex.paloaltonetworks.com/r/Cortex-XPANSE/Cortex-Xpanse-Expander-User-Guide/Automated-Remediation-Capabilities-Matrix
image

@sapirshuker sapirshuker added post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Oct 5, 2023
@content-bot
Copy link
Collaborator

content-bot commented Oct 5, 2023 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6517502

@sapirshuker sapirshuker added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Oct 5, 2023
@sapirshuker
Copy link
Contributor

Build process failed it is a known issue: CIAC-6419

@sapirshuker sapirshuker merged commit 5cfb6d1 into demisto:contrib/PaloAltoNetworks_GCP-EXPANDR-6261 Oct 5, 2023
33 of 34 checks passed
@content-bot content-bot mentioned this pull request Oct 5, 2023
Merged
5 tasks
sapirshuker added a commit that referenced this pull request Oct 5, 2023
@content-bot @johnnywilkes
@ShirleyDenkberg @BigEasyJ @sapirshuker
GCP - Expandr-6261 (#30062)
1a1c8cd 
* GCP - Expandr-6261 (#29951)

* update play

* remove section header

* RN

* Update Packs/GCP-Enrichment-Remediation/ReleaseNotes/1_1_8.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* removed conditonal

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>

* add known words

* fix typo

* remove duplicate vpc word from known words

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
sapirshuker added a commit that referenced this pull request Dec 21, 2023
@content-bot @johnnywilkes
@ShirleyDenkberg @BigEasyJ @sapirshuker
GCP - Expandr-6261 (#30062)
56f63c5 
* GCP - Expandr-6261 (#29951)

* update play

* remove section header

* RN

* Update Packs/GCP-Enrichment-Remediation/ReleaseNotes/1_1_8.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* removed conditonal

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>

* add known words

* fix typo

* remove duplicate vpc word from known words

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@melamedbn melamedbn melamedbn approved these changes

@sapirshuker sapirshuker sapirshuker approved these changes

Assignees

@melamedbn melamedbn

@sapirshuker sapirshuker

@ShirleyDenkberg ShirleyDenkberg

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-demo Demo pending post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
6 participants
@johnnywilkes @content-bot @ShirleyDenkberg @sapirshuker @melamedbn @BigEasyJ