[AbnormalSecurity] Expand integration commands #29994
Conversation
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/wolyslager_expand-integration-commands-2
|
@wolyslager Looks good. Just fix the failing validations and unit-tests. Note that you've changed the release notes of an existing version (2_0_27.md) instead of creating a new one (and the original one of a previous version should remain untouched). I'd recommend just reverting the changes to just revert the changes you made to the release notes file & Also, while making the changes, pull & merge from master (if you see any conflicts to unrelated files like last time don't merge) so that we can run the build after the changes and assure it passes. |
MichaelYochpaz
added
post-demo
pending-contributor
|
@MichaelYochpaz I've fixed the failing tests and created a new release notes file (2_1_0) and reverted the changes on the previous one (2_0_27). I had to manually update the pack metadata to match 2_1_0. I also pulled an merged from master and had no conflicts 😄 - let me know if I need to do anything else! 🙏 |
MichaelYochpaz
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6522773 |
|
@wolyslager There's a validation error -
The Docker version specified in the release-notes doesn't match the one on the YAML file. |
Perfect! Updated it 😄 hopefully that wraps things up 🤞 |
MichaelYochpaz
added
ready-for-instance-test
MichaelYochpaz
merged commit c590ec7
into
demisto:contrib/wolyslager_expand-integration-commands-2
* AbnormalSecurity.py * AbnormalSecurity.yml * AbnormalSecurity_test.py * command_examples * README * adding test data * adding test files * test file content * test file contents * test file contents * test file contents * test file contents * test file * test file content * release notes * Secrets * updating version * updating docker image * adjusting abuse mailbox context path * adding test files * adding test data * adding test files * fixing tests * test data * nit - tests * nit -tests * nit - remove hardcoded last fetch time * remove page numbers from threats command * remove nextPageNumber key * remove hardcoded last fetch time * linting fix * markdown fixes * release notes * fix vendors list command * fix vendor cases command * tests fix * nit - linting error: * update version * fixing context output * dont include vendors key * exclude vendors key * nit * exlude vendorCases key * nit * removing white spacE * fix unit tests * revert pack metadata change * revert release notes change * nit * revert release notes * nit * new release notes file * nit * update pack metadata * fix docker version in release files Co-authored-by: William Olyslager <wolyslager@abnormalsecurity.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
* AbnormalSecurity.py * AbnormalSecurity.yml * AbnormalSecurity_test.py * command_examples * README * adding test data * adding test files * test file content * test file contents * test file contents * test file contents * test file contents * test file * test file content * release notes * Secrets * updating version * updating docker image * adjusting abuse mailbox context path * adding test files * adding test data * adding test files * fixing tests * test data * nit - tests * nit -tests * nit - remove hardcoded last fetch time * remove page numbers from threats command * remove nextPageNumber key * remove hardcoded last fetch time * linting fix * markdown fixes * release notes * fix vendors list command * fix vendor cases command * tests fix * nit - linting error: * update version * fixing context output * dont include vendors key * exclude vendors key * nit * exlude vendorCases key * nit * removing white spacE * fix unit tests * revert pack metadata change * revert release notes change * nit * revert release notes * nit * new release notes file * nit * update pack metadata * fix docker version in release files Co-authored-by: William Olyslager <wolyslager@abnormalsecurity.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Created a new pull request as the previous one got muddled with merge conflict issues
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have