Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS EXPANDR-6233 #30002

Merged
merged 2 commits into from Oct 3, 2023
Merged

Conversation

content-bot
Copy link
Collaborator

@content-bot content-bot commented Oct 3, 2023

Original External PR

external pull request

Contributor

@johnnywilkes

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6233

Description

Added the Region input to specify region to run AWS commands for "AWSRecreateSG" script and playbook that runs it "AWS - Security Group Remediation v2".

Must have

  • Tests
  • Documentation

No mandatory dependencies were added on this pull request.

* update script

* update play

* RN

* fix RN

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* docker update

* clean README

* add predefined regions

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. post-demo Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR Security Review labels Oct 3, 2023
@MichaelYochpaz MichaelYochpaz removed the pending-contributor The PR is pending the response of its creator label Oct 3, 2023
@MichaelYochpaz MichaelYochpaz merged commit 550d01b into master Oct 3, 2023
19 checks passed
@MichaelYochpaz MichaelYochpaz deleted the contrib/PaloAltoNetworks_ASM-EXPANDR-6233 branch October 3, 2023 09:41
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* update script

* update play

* RN

* fix RN

* Apply suggestions from code review



* docker update

* clean README

* add predefined regions

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* update script

* update play

* RN

* fix RN

* Apply suggestions from code review



* docker update

* clean README

* add predefined regions

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
4 participants