Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDL] added enforce_ascii #30010

Merged
merged 12 commits into from Oct 9, 2023
Merged

[EDL] added enforce_ascii #30010

merged 12 commits into from Oct 9, 2023

Conversation

bziser
Copy link
Contributor

@bziser bziser commented Oct 3, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added a parameter named: "Enforce ASCII only" to force the list to contain only ASCII chars (non ascii URLs are dropped).

@bziser bziser marked this pull request as ready for review October 5, 2023 09:28
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Packs/EDL/Integrations/EDL/EDL.yml Outdated Show resolved Hide resolved
Packs/EDL/ReleaseNotes/3_2_11.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@DeanArbel @Ni-Knight Doc review completed.

bziser and others added 2 commits October 5, 2023 14:35
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Copy link
Contributor

@Ni-Knight Ni-Knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a good option for future logging, thank you :)

@bziser bziser merged commit 443a1f2 into master Oct 9, 2023
14 of 15 checks passed
@bziser bziser deleted the add_ascii_param_edl branch October 9, 2023 11:33
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* added enforce_ascii

* docker

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants