[Armis Event Collector] Update initial fetch handling #30030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelFain
deleted the
bugfix/XSUP-28767/armis-collector-fix-initial-fetch
branch
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* Update initial fetch handling * Update docstring * Update Release Notes * Update fetch logic * Add test_set_last_run_with_current_time_initial UT * Add debug log for initial fetch * Add case to test_fetch_flow_cases UT * Update UT * Update UT
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Update initial fetch handling * Update docstring * Update Release Notes * Update fetch logic * Add test_set_last_run_with_current_time_initial UT * Add debug log for initial fetch * Add case to test_fetch_flow_cases UT * Update UT * Update UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
relates: XSUP-28767
Description
This PR sets the last run for the initial fetch, so that the original fetch time would remain constant until events are fetched (and not update the initial fetch time every fetch cycle).
Changes made:
Must have