Xdr ioc not pushed #30039
Merged
Xdr ioc not pushed #30039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorschw
previously requested changes
Oct 4, 2023
| #### Integrations | ||
| ##### Cortex XDR - IOC | ||
|
|
||
| - Added a validation for pushed indicators, using ***xdr-ioc-push*** command. |
There was a problem hiding this comment.
| return {'data': json.dumps({"request_data": _json})} | ||
| data = {"request_data": _json} | ||
| if validate: | ||
| data['validate'] = True |
There was a problem hiding this comment.
This flag basically tells the API to return validation error info?
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
ShahafBenYakir
approved these changes
Oct 10, 2023
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* save adding validation * save rn * fix test * fix ruff * changed to warning * changed to warning * save rn * Update Packs/CortexXDR/ReleaseNotes/5_1_9.md Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> * update docstring --------- Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-28613
Description
Added validation to tell the customer that validation failed and some iocs not pushed.
Must have