Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] - Expander - Add new case_id_list argument #30048

Merged
merged 16 commits into from Nov 2, 2023
Merged

[ASM] - Expander - Add new case_id_list argument #30048

merged 16 commits into from Nov 2, 2023

Conversation

andrew-paloalto
Copy link
Contributor

@andrew-paloalto andrew-paloalto commented Oct 4, 2023 •
edited

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6374

Description

Adds support for the new case_id_list param in the alerts API.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 4, 2023
@content-bot content-bot changed the base branch from master to contrib/andrew-paloalto_xpanse_case_id-1 October 4, 2023 15:41
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @andrew-paloalto, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@johnnywilkes
Copy link
Contributor

Andrew said this arg isn't built into the API yet. When it is, we can test and approve.

@sapirshuker
Copy link
Contributor

sapirshuker commented Oct 8, 2023 •
edited

Hey, @johnnywilkes thank you for your contribution. I can see that your PR is Draft. I would appreciate it if you let me know when the PR is ready so that we can move forward with the contribution process.

@johnnywilkes
Copy link
Contributor

@sapirshuker , we are waiting for this new API to go live and to do some more testing, please hold off on any review until we mention you. Thanks!

@andrew-paloalto andrew-paloalto marked this pull request as ready for review October 27, 2023 18:24
johnnywilkes
johnnywilkes approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-paloalto , looks good, approved

@sapirshuker sapirshuker added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Nov 1, 2023
@content-bot
Copy link
Collaborator

content-bot commented Nov 1, 2023 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6775731

@sapirshuker
Copy link
Contributor

@ShirleyDenkberg Please review

ShirleyDenkberg
ShirleyDenkberg reviewed Nov 1, 2023
View reviewed changes
Packs/CortexXpanse/Integrations/CortexXpanse/CortexXpanse.yml Outdated
@@ -423,6 +423,8 @@ script:
name: lte_creation_time
- description: A date in the format 2019-12-31T23:59:00. Only incidents that were created on or after the specified date/time will be retrieved.
name: gte_creation_time
- description: Comma-separated list of integers of the case (Incident) ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be changed to just:
Comma-separated list of case (incident) IDs.

Packs/CortexXpanse/Integrations/CortexXpanse/README.md Outdated Show resolved Hide resolved
Packs/CortexXpanse/ReleaseNotes/1_0_13.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@johnnywilkes @sapirshuker Doc review completed.

andrew-paloalto and others added 3 commits November 1, 2023 11:36
@andrew-paloalto @ShirleyDenkberg
Apply suggestions from code review
504ff96 
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@andrew-paloalto
doc update
90bb71d
@andrew-paloalto
Merge branch 'xpanse_case_id' of https://github.com/andrew-paloalto/c…
0eaf911 
…ontent into xpanse_case_id
@andrew-paloalto
Copy link
Contributor Author

@sapirshuker doc updates have been completed

@sapirshuker
Copy link
Contributor

@andrew-paloalto Is it ready for merging?

@sapirshuker sapirshuker added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Nov 2, 2023
@johnnywilkes
Copy link
Contributor

@sapirshuker , andrew is traveling. This is ready to merge

@sapirshuker sapirshuker added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Nov 2, 2023
@sapirshuker sapirshuker added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Nov 2, 2023
@sapirshuker sapirshuker added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Nov 2, 2023
@sapirshuker sapirshuker merged commit 990149d into demisto:contrib/andrew-paloalto_xpanse_case_id-1 Nov 2, 2023
25 of 26 checks passed
@content-bot content-bot mentioned this pull request Nov 2, 2023
Merged
5 tasks
sapirshuker added a commit that referenced this pull request Nov 5, 2023
@content-bot @andrew-paloalto
@sapirshuker @ShirleyDenkberg
[ASM] - Expander - Add new case_id_list argument (#30048) (#30640)
9ae7a26 
* Add case_id_list param

* update release notes

* handle merge conflict

* bump to 1.0.13

* list as ints

* Apply suggestions from code review



* doc update

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
sapirshuker added a commit that referenced this pull request Dec 21, 2023
@content-bot @andrew-paloalto
@sapirshuker @ShirleyDenkberg
[ASM] - Expander - Add new case_id_list argument (#30048) (#30640)
4e635d1 
* Add case_id_list param

* update release notes

* handle merge conflict

* bump to 1.0.13

* list as ints

* Apply suggestions from code review



* doc update

---------

Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com>
Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@johnnywilkes johnnywilkes johnnywilkes approved these changes

@sapirshuker sapirshuker sapirshuker approved these changes

Assignees

@sapirshuker sapirshuker

@ShirleyDenkberg ShirleyDenkberg

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
5 participants
@andrew-paloalto @content-bot @johnnywilkes @sapirshuker @ShirleyDenkberg