Updates to prevent additions of dup url entries and ignore case when deleting url entries #30053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
added
Community
Contribution Form Filled
content-bot
changed the base branch from
master
to
contrib/ali-sawyer_symantec-management-center-updates
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. |
|
Hi @ali-sawyer, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link. |
omerKarkKatz
requested review from
MosheEichler
and removed request for
ilappe
There was a problem hiding this comment.
@ali-sawyer
Thank you for contributing, amaizing work!!
Plesae see my few comments.
@ShirleyDenkberg Can you please review the release notes?
.../SymantecManagementCenter/Integrations/SymantecManagementCenter/SymantecManagementCenter.yml
Outdated
Show resolved
Hide resolved
.../SymantecManagementCenter/Integrations/SymantecManagementCenter/SymantecManagementCenter.yml
Outdated
Show resolved
Hide resolved
MosheEichler
added
the
pending-contributor
.../SymantecManagementCenter/Integrations/SymantecManagementCenter/SymantecManagementCenter.yml
Outdated
Show resolved
Hide resolved
|
@MosheEichler Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
…awyer/content into symantec-management-center-updates
|
Thank you for your review, @MosheEichler and @ShirleyDenkberg. Suggested changes made. |
MosheEichler
approved these changes
Oct 15, 2023
MosheEichler
merged commit 7a69e76
into
demisto:contrib/ali-sawyer_symantec-management-center-updates
13 of 20 checks passed
Merged
5 tasks
MosheEichler
added a commit
that referenced
this pull request
Oct 15, 2023
…deleting url entries (#30164) * Updates to prevent additions of dup url entries and ignore case when deleting url entries (#30053) * changes to prevent additions of dup url entries and ignore case * Fix docs typo Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * incorporate review changes * change back first few lines to match current version, and remove trailing newlines --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * pre-commit fixes * format yml file --------- Co-authored-by: Ali Sawyer <91506078+ali-sawyer@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
…deleting url entries (#30164) * Updates to prevent additions of dup url entries and ignore case when deleting url entries (#30053) * changes to prevent additions of dup url entries and ignore case * Fix docs typo Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * incorporate review changes * change back first few lines to match current version, and remove trailing newlines --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * pre-commit fixes * format yml file --------- Co-authored-by: Ali Sawyer <91506078+ali-sawyer@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
N/A
Description
Make changes to:
add_policy_content_request()delete_policy_content_request()Must have