Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] EXPANDR-6261 #30086

Merged
merged 5 commits into from Oct 9, 2023
Merged

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@johnnywilkes

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6261

Description

Bug fix for GCP Enrichment/remediation

Must have

  • Tests
  • Documentation

* temp ver to mostly delete

* init

* SS

* RN

* Change view keys to unescaped json

* bump

---------

Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR Security Review labels Oct 8, 2023

##### Cortex ASM - GCP Enrichment

Updated the playbook to only store VPC network associated with the public IP address of the alert in the `${asmsystemids(val.type='ASSET-VIRTUAL-NET').id}` field (in the case that the VM has multiple interfaces on different VPC networks).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Updated the playbook to only store VPC network associated with the public IP address of the alert in the `${asmsystemids(val.type='ASSET-VIRTUAL-NET').id}` field (in the case that the VM has multiple interfaces on different VPC networks).
Updated the playbook to only store VPC networks associated with the public IP address of the alert in the `${asmsystemids(val.type='ASSET-VIRTUAL-NET').id}` field (in the case that the VM has multiple interfaces on different VPC networks).

@ShirleyDenkberg
Copy link
Contributor

@MosheEichler Doc review completed.

@MosheEichler MosheEichler merged commit 7648025 into master Oct 9, 2023
15 checks passed
@MosheEichler MosheEichler deleted the contrib/PaloAltoNetworks_ASM-EXPANDR-6261 branch October 9, 2023 07:25
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* [ASM] EXPANDR-6261 (#30072)

* temp ver to mostly delete

* init

* SS

* RN

* Change view keys to unescaped json

* bump

---------

Co-authored-by: bigeasyj <janny@paloaltonetworks.com>

* ignore not-known words

* docs review

* remove vpc

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
5 participants