Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open cti unknown score #30099

Merged
merged 10 commits into from Oct 12, 2023
Merged

Open cti unknown score #30099

merged 10 commits into from Oct 12, 2023

Conversation

jbabazadeh
Copy link
Contributor

@jbabazadeh jbabazadeh commented Oct 9, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [] In Progress
  • [X ] Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-28925

Description

remove score default values from opencti-get-indicators command

Must have

  • Tests
  • Documentation

to get all scores include UNKNOWN score
Copy link
Contributor

@anara123 anara123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a relevant unit test

Packs/OpenCTI/ReleaseNotes/1_0_9.md Outdated Show resolved Hide resolved
@jbabazadeh jbabazadeh merged commit 79d0bfc into master Oct 12, 2023
18 checks passed
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* remove default score
to get all scores include UNKNOWN score

* RN

* added score argument
 to opencti-get-indicators command

* Update Packs/OpenCTI/ReleaseNotes/1_0_9.md

Co-authored-by: Anar Azadaliyev <aazadaliyev@paloaltonetworks.com>

* UT

---------

Co-authored-by: Anar Azadaliyev <aazadaliyev@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants