[Marketplace Contribution] Akamai WAF - Content Pack Update #30111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "contribution update to pack "Akamai WAF""
* Update Akamai_WAF.py
Added [0] to line entry_context.append(raw_response.get('siteShieldMaps'))
human_readable.append(raw_response.get('siteShieldMaps'))
* Update Akamai_WAF.py
1) Added additional validations when all "enrollment_path", "enrollment_id", "change_id" are all blank.
2) Added Dateparer for input dates
* Update Akamai_WAF.yml
Added output for both commands:
akamai-get-cps-enrollment-deployment
akamai-get-cps-change-status
Added additional description for both arguments:
enrollment_id
change_id
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/ReleaseNotes/2_0_8.md
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Akamai_WAF.yml
Updated "akamai-update-cps-enrollment-schedule" command's Arguments to predefined value.
* Update Akamai_WAF.yml
Updated "akamai-update-cps-enrollment" commmand's Arguments.
* Update Akamai_WAF.yml
Updated command outputs descriptions and types.
* Update Akamai_WAF.yml
Updated Command Output descriptions and types
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
* updated the yml according to master
---------
Co-authored-by: davistonehub <111578758+davistonehub@users.noreply.github.com>
Co-authored-by: RotemAmit <ramit@paloaltonetworks.com>
content-bot
added
Contribution
RotemAmit
requested review from
RotemAmit
and removed request for
omerKarkKatz
…r-contrib_davistonehub-contrib-Akamai_WAF-1
| - ***akamai-update-cps-enrollment*** | ||
| - ***akamai-update-cps-enrollment-schedule*** | ||
| - ***akamai-get-cps-change-status*** | ||
| - Updated the ***akamai-update-change*** with a new parameter named "key_algorithm" to allow "ECDSA" format in addition to "RSA" |
There was a problem hiding this comment.
Suggested change
| - Updated the ***akamai-update-change*** with a new parameter named "key_algorithm" to allow "ECDSA" format in addition to "RSA" | |
| - Updated the ***akamai-update-change*** comman with a new parameter named "key_algorithm" to allow "ECDSA" format in addition to "RSA". |
|
@RotemAmit After implementing doc comments in the yml file, regenerate the integration readme. |
|
After adding unit tests to all of the new commands in this contribution, the coverage is 22.8%. |
eyalpalo
approved these changes
Oct 23, 2023
RotemAmit
approved these changes
Oct 23, 2023
ShahafBenYakir
deleted the
contrib/xsoar-contrib_davistonehub-contrib-Akamai_WAF-1
branch
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* [Marketplace Contribution] Akamai WAF - Content Pack Update (#29671) * "contribution update to pack "Akamai WAF"" * Update Akamai_WAF.py Added [0] to line entry_context.append(raw_response.get('siteShieldMaps')) human_readable.append(raw_response.get('siteShieldMaps')) * Update Akamai_WAF.py 1) Added additional validations when all "enrollment_path", "enrollment_id", "change_id" are all blank. 2) Added Dateparer for input dates * Update Akamai_WAF.yml Added output for both commands: akamai-get-cps-enrollment-deployment akamai-get-cps-change-status Added additional description for both arguments: enrollment_id change_id * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/ReleaseNotes/2_0_8.md Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Akamai_WAF.yml Updated "akamai-update-cps-enrollment-schedule" command's Arguments to predefined value. * Update Akamai_WAF.yml Updated "akamai-update-cps-enrollment" commmand's Arguments. * Update Akamai_WAF.yml Updated command outputs descriptions and types. * Update Akamai_WAF.yml Updated Command Output descriptions and types * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * updated the yml according to master --------- Co-authored-by: davistonehub <111578758+davistonehub@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * README.md * format of yml file and pre-commit * added test_get_cps_enrollment_deployment_command_production * pre-commit changes and first test updates * updated the dates, mypy updates and docker image update * fixed trailing whitespaces * updated the dates issue to be a function, more test * final tests * test_try_parsing_date * doc-review changes * readme and docker image update * fixed a test and release notes --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: davistonehub <111578758+davistonehub@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Status
Contributor
@davistonehub
Notes
To whom it may concern, FIS is using Cloud-based Dev instance offered by Palo and all the development work is carried out via Dev's Web Interface.
Debug log of the execution for each command will be provided as review reference instead of Demo Video Link.
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.