Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - EXPANDR-6449 - Fixing GCP Bug #30126

Merged
merged 2 commits into from Oct 12, 2023
Merged

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@capanw

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6449

Description

Fixing GCP bug when there are no network tags on the instance.

Must have

  • Tests
  • Documentation

* Fixing GCP Bug - EXPANDR-6449

* Misc updates

* Fixed readme file

* Added prisma to known words

* fixed readme
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR Security Review labels Oct 12, 2023
@MosheEichler
Copy link
Contributor

@ShirleyDenkberg Can you please confirm the release notes?

id: 25fb1d61-58d0-4aef-85db-8cd927573a66
version: -1
name: Are there any Network tags?
description: Checks if there are network tags items.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Checks if there are network tags items.
description: Checks if there are network tags.


##### Cortex ASM - Prisma Cloud Enrichment

- Fixed an issue with no network tags logic. Now we have an additional check for this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed an issue with no network tags logic. Now we have an additional check for this.
Fixed an issue with no network tags logic. Now there is an additional check for this.

@ShirleyDenkberg
Copy link
Contributor

@MosheEichler @melamedbn Doc review completed.

@MosheEichler MosheEichler merged commit d82b716 into master Oct 12, 2023
15 checks passed
@MosheEichler MosheEichler deleted the contrib/capanw_EXPANDR-6449 branch October 12, 2023 10:42
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Fixing GCP Bug - EXPANDR-6449

* Misc updates

* Fixed readme file

* Added prisma to known words

* fixed readme

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
5 participants