Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma cloud aws ec2 remediation fix #30193

Merged
merged 5 commits into from Oct 18, 2023

Conversation

tomer-pan
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-8662

Description

Remove deprecated policies from "Prisma Cloud Remediation - AWS EC2 Instance Misconfiguration v2" playbook and related sub-playbook.

@ShirleyDenkberg ShirleyDenkberg self-assigned this Oct 17, 2023
@ShirleyDenkberg ShirleyDenkberg added the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Oct 17, 2023
- AWS Security Groups allow internet traffic from internet to PostgreSQL port (5432)
- AWS Security Groups allow internet traffic from internet to VNC Listener port (5500)
- AWS Security Groups allow internet traffic from internet to VNC Server port (5900)
- AWS Default Security Group Does Not Restrict All Traffic (policy id: 2378dbf4-b104-4bda-9b05-7417affbba3f)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does capitalization matter? Should this be: AWS Default Security Group does not restrict all traffic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names are identical to how the appear on Prisma Cloud's side.

Removed sections related to Prisma Cloud's deprecated policies.
##### Prisma Cloud Remediation - AWS EC2 Instance Misconfiguration v2

Removed Prisma Cloud's deprecated policy IDs from task #17.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a link? Why is it underlined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a link - probably a github parsing thing.

@ShirleyDenkberg
Copy link
Contributor

@efelmandar Doc review completed.

@tomer-pan tomer-pan merged commit 74ff104 into master Oct 18, 2023
21 of 22 checks passed
@tomer-pan tomer-pan deleted the Prisma_Cloud_AWS_EC2_Remediation_Fix branch October 18, 2023 06:26
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* playbooks fix

* RN

* remove paths

* add image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process
Projects
None yet
3 participants