packs/reco: change path of url #30204
Conversation
content-bot
added
Partner-Approved
Contribution Form Filled
GalNakash-RecoLabs
force-pushed
the
fix/path-url
branch
from
09dda64
to
95e0ec0
Compare
content-bot
changed the base branch from
master
to
contrib/RecoLabs_fix/path-url
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed. |
Change alerts path Signed-off-by: Gal Nakash <gal@recolabs.ai>
GalNakash-RecoLabs
force-pushed
the
fix/path-url
branch
from
95e0ec0
to
4cf0650
Compare
|
@sapirshuker let me know if anything is missing |
|
Hey, @GalNakash-RecoLabs |
There was a problem hiding this comment.
Hey, thank you for your contribution.
The code looks good!
Please solve the errors in the build
| @@ -191,7 +191,7 @@ def get_alerts( | |||
| try: | |||
| response = self._http_request( | |||
| method="PUT", | |||
| url_suffix="/alert-inbox/table", | |||
| url_suffix="/policy-subsystem/alert-inbox/table", | |||
There was a problem hiding this comment.
What is the effect of this change on backward compatibility?
There was a problem hiding this comment.
No backward compatibility - we changed it
Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com>
|
Hey, @GalNakash-RecoLabs |
|
We changed all our endpoints path and we don’t support the old endpoint .
The functionality is the same. It’s pretty urgent for us
Sent via Superhuman iOS ( ***@***.*** )
…On Wed, Oct 18 2023 at 5:09 PM, sapir shuker < ***@***.*** > wrote:
Hey, @GalNakash-RecoLabs ( https://github.com/GalNakash-RecoLabs )
I would be happy to know why you did this change?
Does the new endpoint match the old endpoint?
Do the results from the endpoint align with the results from the old
endpoint? (the results is the same for both)
Thanks
—
Reply to this email directly, view it on GitHub (
#30204 (comment) ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AQ7NTGSHZMOPPXTTXMWI24DX77PJVAVCNFSM6AAAAAA6CSTTMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRYGU2DKMRVG4
).
You are receiving this because you were mentioned. Message ID: <demisto/content/pull/30204/c1768545257
@ github. com>
|
|
Hey, @GalNakash-RecoLabs, the code looks good! |
sapirshuker
added
pending-demo
|
I'm in miluim.
I will record a demo over the weekend and share it with you.
Best,
Gal
Sent via Superhuman iOS ( ***@***.*** )
…On Thu, Oct 19 2023 at 10:19 AM, sapir shuker < ***@***.*** > wrote:
Hey, @GalNakash-RecoLabs ( https://github.com/GalNakash-RecoLabs ) , the
code looks good!
We're ready for a demo. Please check this page (
https://xsoar.pan.dev/docs/contributing/demo-prep ) , and let me know when
you're available for one over DFIR.
—
Reply to this email directly, view it on GitHub (
#30204 (comment) ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AQ7NTGTR3BFR4LFORVGQL23YADH6PAVCNFSM6AAAAAA6CSTTMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQGIYDONZRGY
).
You are receiving this because you were mentioned. Message ID: <demisto/content/pull/30204/c1770207716
@ github. com>
|
|
Hey, @GalNakash-RecoLabs |
sapirshuker
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6681276 |
sapirshuker
merged commit b42c831
into
demisto:contrib/RecoLabs_fix/path-url
* packs/reco: change path of url (#30204) * packs/reco: change path of url Change alerts path Signed-off-by: Gal Nakash <gal@recolabs.ai> * Update Packs/Reco/ReleaseNotes/1_1_7.md Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com> --------- Signed-off-by: Gal Nakash <gal@recolabs.ai> Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com> * update docker image and period issue --------- Signed-off-by: Gal Nakash <gal@recolabs.ai> Co-authored-by: GalNakash-RecoLabs <71227802+GalNakash-RecoLabs@users.noreply.github.com> Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com> Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
* packs/reco: change path of url (#30204) * packs/reco: change path of url Change alerts path Signed-off-by: Gal Nakash <gal@recolabs.ai> * Update Packs/Reco/ReleaseNotes/1_1_7.md Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com> --------- Signed-off-by: Gal Nakash <gal@recolabs.ai> Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com> * update docker image and period issue --------- Signed-off-by: Gal Nakash <gal@recolabs.ai> Co-authored-by: GalNakash-RecoLabs <71227802+GalNakash-RecoLabs@users.noreply.github.com> Co-authored-by: sapir shuker <49246861+sapirshuker@users.noreply.github.com> Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
Change alerts path
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have