[Marketplace Contribution] Dragos Worldview - Content Pack Update #30207

xsoar-bot · 2023-10-16T19:27:41Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

Notes

I can send the demo video through slack

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

content-bot · 2023-10-16T19:29:54Z

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @ilappe will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

FIxed error with missing period in description

Fixed spelling mistake

Added a period to the end of all command, argument, and output descriptions

Added input and output tables for dragos-get-indicators()

Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview.py

Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview_description.md

randomizerxd · 2023-10-20T18:45:14Z

Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview.yml

    name: dragos-get-stix2
-  dockerimage: demisto/python3:3.10.12.63474
+  dockerimage: demisto/python3:3.10.13.75921


@NicCas update docker image to demisto/python3:3.10.13.77674

Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview.yml

Split username/password setup of credential into two password only ones. Added back old encrypted parameters for backwards compatibility

Updated key and token check to support old encryption and new credential parameters.

…nto NicCas-contrib-DragosWorldview

ilappe

Thanks @NicCas for your contribution!
please see my few comments
in addition, can you please,

provide me a command_example file as described here , we will need it to generate the README with more information about the args and context outputs.
prepare a short video that show the updated command run in the war room with/without the new args and see the result and the context ?
you can send them via DFIR in slack.
thanks again!

Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview.py

Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview.yml

…view.yml Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>

Added bug fix where multiple page numbers could be in an api call Added suggested Boolean wrapper and default

ilappe · 2023-10-24T07:07:33Z

Hi @NicCas thanks for implementing the fixes!!
i see there is workflows that failed (looks like lint error).
in addition, when the PR are ready to re-review, please click on the request re-review button under the reviewers section
thanks!

NicCas · 2023-10-24T18:49:12Z

Hi @NicCas thanks for implementing the fixes!! i see there is workflows that failed (looks like lint error). in addition, when the PR are ready to re-review, please click on the request re-review button under the reviewers section thanks!

I don't see this button but the changes are ready for review!

ilappe · 2023-10-25T11:35:27Z

Thanks @NicCas for implementing the fixes!!
see one point that remain to check
in addition, are you able to follow the requests in this comment?

…nto NicCas-contrib-DragosWorldview

content-bot · 2023-10-26T07:52:31Z

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6711212

…nto NicCas-contrib-DragosWorldview

Added descriptions to the integration parameters Changed order of columns for !dragos-get-indicators() output table Added example commands for all 4 integration commands

…nto NicCas-contrib-DragosWorldview

…soar-contrib/content into pr/xsoar-bot/30207

ilappe

Thanks @NicCas for this contribution!

…0207) (#30504) * "contribution update to pack "Dragos Worldview"" * Update DragosWorldview.yml FIxed error with missing period in description * Update DragosWorldview_description.md Fixed spelling mistake * Update DragosWorldview.yml Added a period to the end of all command, argument, and output descriptions * Update README.md Added input and output tables for dragos-get-indicators() * Changed credential for backwards compatibility Split username/password setup of credential into two password only ones. Added back old encrypted parameters for backwards compatibility * Added backwards compatibility for credentials Updated key and token check to support old encryption and new credential parameters. * Updated docker image tag * Added back link * Updating docker image * Update Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview.yml * Update Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorldview.yml * Update DragosWorldview.py Added bug fix where multiple page numbers could be in an api call Added suggested Boolean wrapper and default * Removed redundant boolean check * changed output's key field back to indicator_id * Added suggested int wrapper for page * Fixed formatting issues and updated docker * Changed id > indicator_id in outputs * Removed parathesis for bug fix * Type casted raw_response[...] to int * Added requested changes Added descriptions to the integration parameters Changed order of columns for !dragos-get-indicators() output table Added example commands for all 4 integration commands * Added human readable output for dragos-get-indicators() * Added human readable output example for dragos-get-indicators() * Update 1_1_3.md * update README - fix validation * update correct README --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> Co-authored-by: ilappe <ilappe@paloaltonetworks.com>

"contribution update to pack "Dragos Worldview""

40dd76e

content-bot added Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Oct 16, 2023

content-bot changed the base branch from master to contrib/xsoar-contrib_NicCas-contrib-DragosWorldview October 16, 2023 19:29

content-bot assigned ilappe Oct 16, 2023

content-bot requested a review from ilappe October 16, 2023 19:29

NicCas added 4 commits October 17, 2023 09:53

Update DragosWorldview.yml

ffa2f69

FIxed error with missing period in description

Update DragosWorldview_description.md

5894f08

Fixed spelling mistake

Update DragosWorldview.yml

04fdc5e

Added a period to the end of all command, argument, and output descriptions

Update README.md

72eb414

Added input and output tables for dragos-get-indicators()

randomizerxd suggested changes Oct 20, 2023

View reviewed changes

NicCas added 6 commits October 20, 2023 13:14

Changed credential for backwards compatibility

7ca9cce

Split username/password setup of credential into two password only ones. Added back old encrypted parameters for backwards compatibility

Added backwards compatibility for credentials

f260e99

Updated key and token check to support old encryption and new credential parameters.

Updated docker image tag

c6cb164

Added back link

d985140

Merge branch 'contrib/xsoar-contrib_NicCas-contrib-DragosWorldview' i…

3d34ac2

…nto NicCas-contrib-DragosWorldview

Updating docker image

ad1c629

ilappe requested changes Oct 22, 2023

View reviewed changes

ilappe added the pending-contributor The PR is pending the response of its creator label Oct 22, 2023

NicCas and others added 6 commits October 23, 2023 15:13

Update Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorld…

dc1d4b4

…view.yml Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>

Update Packs/DragosWorldview/Integrations/DragosWorldview/DragosWorld…

01d4404

…view.yml Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>

Update DragosWorldview.py

5913f1a

Added bug fix where multiple page numbers could be in an api call Added suggested Boolean wrapper and default

Removed redundant boolean check

dbf3430

changed output's key field back to indicator_id

20b256f

Added suggested int wrapper for page

db39a98

ilappe removed the pending-contributor The PR is pending the response of its creator label Oct 24, 2023

ilappe added the pending-contributor The PR is pending the response of its creator label Oct 24, 2023

NicCas added 2 commits October 24, 2023 11:44

Fixed formatting issues and updated docker

fe69540

Changed id > indicator_id in outputs

b980c02

Removed parathesis for bug fix

81c0a3a

Merge branch 'contrib/xsoar-contrib_NicCas-contrib-DragosWorldview' i…

2af7eee

…nto NicCas-contrib-DragosWorldview

ilappe added post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Oct 26, 2023

Merge branch 'contrib/xsoar-contrib_NicCas-contrib-DragosWorldview' i…

7081e24

…nto NicCas-contrib-DragosWorldview

ilappe added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Oct 26, 2023

NicCas and others added 12 commits October 26, 2023 09:13

Merge branch 'contrib/xsoar-contrib_NicCas-contrib-DragosWorldview' i…

8eef7d9

…nto NicCas-contrib-DragosWorldview

Merge branch 'contrib/xsoar-contrib_NicCas-contrib-DragosWorldview' i…

6393db7

…nto NicCas-contrib-DragosWorldview

Type casted raw_response[...] to int

8d1ed22

Merge branch 'contrib/xsoar-contrib_NicCas-contrib-DragosWorldview' i…

0b6e675

…nto NicCas-contrib-DragosWorldview

Added requested changes

4422191

Added descriptions to the integration parameters Changed order of columns for !dragos-get-indicators() output table Added example commands for all 4 integration commands

Added human readable output for dragos-get-indicators()

42f4fba

Added human readable output example for dragos-get-indicators()

a916747

Merge branch 'contrib/xsoar-contrib_NicCas-contrib-DragosWorldview' i…

fe091c9

…nto NicCas-contrib-DragosWorldview

Update 1_1_3.md

649d3fc

update README - fix validation

cf5d855

Merge branch 'NicCas-contrib-DragosWorldview' of https://github.com/x…

a183687

…soar-contrib/content into pr/xsoar-bot/30207

update correct README

80e5b4c

ilappe approved these changes Oct 29, 2023

View reviewed changes

ilappe merged commit 49aae38 into demisto:contrib/xsoar-contrib_NicCas-contrib-DragosWorldview Oct 29, 2023
17 of 20 checks passed

content-bot mentioned this pull request Oct 29, 2023

[Marketplace Contribution] Dragos Worldview - Content Pack Update #30504

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace Contribution] Dragos Worldview - Content Pack Update #30207

[Marketplace Contribution] Dragos Worldview - Content Pack Update #30207

xsoar-bot commented Oct 16, 2023

content-bot commented Oct 16, 2023

randomizerxd Oct 20, 2023

ilappe left a comment

ilappe commented Oct 24, 2023

NicCas commented Oct 24, 2023

ilappe commented Oct 25, 2023

content-bot commented Oct 26, 2023 •

edited

ilappe left a comment

[Marketplace Contribution] Dragos Worldview - Content Pack Update #30207

[Marketplace Contribution] Dragos Worldview - Content Pack Update #30207

Conversation

xsoar-bot commented Oct 16, 2023

Status

Contributor

Notes

Video Link

content-bot commented Oct 16, 2023

randomizerxd Oct 20, 2023

Choose a reason for hiding this comment

ilappe left a comment

Choose a reason for hiding this comment

ilappe commented Oct 24, 2023

NicCas commented Oct 24, 2023

ilappe commented Oct 25, 2023

content-bot commented Oct 26, 2023 • edited

ilappe left a comment

Choose a reason for hiding this comment

content-bot commented Oct 26, 2023 •

edited